React Native#53651
Closed
yury-dymov wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81727845 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81727845 |
yury-dymov
force-pushed
the
export-D81727845
branch
from
9d00ea2 to
0cc1b2e
Compare
Summary: Pull Request resolved: facebook#53651 ## Stack We aim to remove +load methods from the codebase to reduce pre-main startup time and to unblock enabling startup optimizations # Diff Diff removes `+load` API from `RCT_EXPORT_MODULE` macro. It introduces new parameter for `react_native_module_provider` function `eager`, which adds legacy RN modules to newly created socket `REACT_MODULE_EAGER_REGISTRATION_SOCKET`. This socket is invoked right before the RCTBridge is being initialized. Impact: 137 static loaders are removed from the startup path Reviewed By: RSNara Differential Revision: D81727845
Contributor
|
@yury-dymov has exported this pull request. If you are a Meta employee, you can view the originating diff in D81727845. |
yury-dymov
force-pushed
the
export-D81727845
branch
from
0cc1b2e to
cb7f7c3
Compare
Contributor
|
This pull request has been merged in a7dc505. |
Collaborator
|
This pull request was successfully merged by Yury Dymov in a7dc505 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Stack
We aim to remove +load methods from the codebase to reduce pre-main startup time and to unblock enabling startup optimizations
Diff
Diff removes
+loadAPI fromRCT_EXPORT_MODULEmacro.It introduces new parameter for
react_native_module_providerfunctioneager, which adds legacy RN modules to newly created socketREACT_MODULE_EAGER_REGISTRATION_SOCKET. This socket is invoked right before the RCTBridge is being initialized.Impact: 137 static loaders are removed from the startup path
Differential Revision: D81727845