Add API 26 check to ReactScrollViewHelper#53688
Closed
Abbondanzo wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82039300 |
Abbondanzo
force-pushed
the
export-D82039300
branch
from
39d4bf2 to
e2d1cae
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82039300 |
Abbondanzo
force-pushed
the
export-D82039300
branch
from
e2d1cae to
9be2332
Compare
Summary: Pull Request resolved: facebook#53688 Support for the `removeIf` method was [added to CopyOnWriteArrayList with AOSP in API 26](https://android-review.googlesource.com/c/platform/libcore/+/304056). On devices with API 24 and 25, invocations of either `ReactScrollViewHelper#removeScrollListener` or `ReactScrollViewHelper#removeLayoutChangeListener` would cause a crash. Rather than bump the required API version and lock out apps targeting API 24/25, this adds a separate code path to bulk remove items from the array list. Changelog: [Internal] Differential Revision: D82039300
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82039300 |
Abbondanzo
force-pushed
the
export-D82039300
branch
from
9be2332 to
85aefd9
Compare
Contributor
|
This pull request has been merged in 0ee665c. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in 0ee665c When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Support for the
removeIfmethod was added to CopyOnWriteArrayList with AOSP in API 26. On devices with API 24 and 25, invocations of eitherReactScrollViewHelper#removeScrollListenerorReactScrollViewHelper#removeLayoutChangeListenerwould cause a crash. Rather than bump the required API version and lock out apps targeting API 24/25, this adds a separate code path to bulk remove items from the array list.Changelog: [Internal]
Rollback Plan:
Differential Revision: D82039300