Do not invoke project. inside BundleHermesCTask#53718
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82130643 |
cortinico
force-pushed
the
export-D82130643
branch
from
4baa6bb to
288f1d5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82130643 |
cortinico
force-pushed
the
export-D82130643
branch
from
288f1d5 to
4362571
Compare
cortinico
force-pushed
the
export-D82130643
branch
from
4362571 to
859336e
Compare
Summary: Pull Request resolved: facebook#53718 I've just realized we ended up invoking `project.` inside the execution of `BundleHermesCTask`. This is an anti-pattern and is breaking Gradle Configuration caching. Instead we should be checking if hermesV1Enabled is set during the Task registration and pass over this information to the task. Changelog: [Internal] [Changed] - Reviewed By: j-piasecki Differential Revision: D82130643
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82130643 |
cortinico
force-pushed
the
export-D82130643
branch
from
859336e to
b20bcf9
Compare
Collaborator
|
This pull request was successfully merged by @cortinico in 29c1f72 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in 29c1f72. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I've just realized we ended up invoking
project.inside the execution ofBundleHermesCTask.This is an anti-pattern and is breaking Gradle Configuration caching.
Instead we should be checking if hermesV1Enabled is set during the Task registration and pass over this information
to the task.
Changelog:
[Internal] [Changed] -
Differential Revision: D82130643