ensure animatedNodes collection is only accessed on render thread#53734
Closed
zeyap wants to merge 1 commit into
Closed
ensure animatedNodes collection is only accessed on render thread#53734zeyap wants to merge 1 commit into
zeyap wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82119554 |
…cebook#53734) Summary: ## Changelog: [Internal] [Changed] - ensure animatedNodes collection is only accessed on render thread now `createAnimatedNode` can be called async from js thread (since facebook#53476), `animatedNodes_` will be written on both threads, there was no proper locking mechanism for read we can simply add locks wherever we read/write animatedNodes_; but there's way to use fewer locking - since AnimatedNode is created async, but will not be R/W async anywhere else, we can add a new collection to temporarily hold nodes created async and flush it on render thread Reviewed By: lenaic Differential Revision: D82119554
zeyap
force-pushed
the
export-D82119554
branch
from
0ae6d1f to
2b4789e
Compare
Contributor
Contributor
|
This pull request has been merged in 54ebfaf. |
Collaborator
|
This pull request was successfully merged by @zeyap in 54ebfaf When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Changed] - ensure animatedNodes collection is only accessed on render thread
now
createAnimatedNodecan be called async from js thread (since #53476),animatedNodes_will be written on both threads, there was no proper locking mechanism for readwe can simply add locks wherever we read/write animatedNodes_; but there's way to use fewer locking - since AnimatedNode is created async, but will not be R/W async anywhere else, we can add a new collection to temporarily hold nodes created async and flush it on render thread
Differential Revision: D82119554