Add Array.push API
#53762
Open
Add Array.push API
#53762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating diff in D82254334. |
tsaichien
force-pushed
the
export-D82254334
branch
from
7740e7e to
4d88852
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Sep 12, 2025
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Differential Revision: D82254334
Contributor
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating diff in D82254334. |
tsaichien
force-pushed
the
export-D82254334
branch
from
4d88852 to
cc37350
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Sep 24, 2025
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Differential Revision: D82254334
Contributor
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating diff in D82254334. |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Sep 24, 2025
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Differential Revision: D82254334
tsaichien
force-pushed
the
export-D82254334
branch
from
cc37350 to
d05a581
Compare
Contributor
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating diff in D82254334. |
tsaichien
force-pushed
the
export-D82254334
branch
from
d05a581 to
ed3014b
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Sep 27, 2025
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Differential Revision: D82254334
Contributor
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating diff in D82254334. |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Oct 1, 2025
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D82254334
tsaichien
force-pushed
the
export-D82254334
branch
from
ed3014b to
a044b4f
Compare
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82254334. |
tsaichien
force-pushed
the
export-D82254334
branch
from
a044b4f to
484991d
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Oct 3, 2025
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D82254334
tsaichien
force-pushed
the
export-D82254334
branch
from
484991d to
688b5a0
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Oct 7, 2025
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D82254334
tsaichien
force-pushed
the
export-D82254334
branch
from
688b5a0 to
31e97b6
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 16, 2025
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Differential Revision: D82254334
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Jan 22, 2026
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Differential Revision: D82254334
tsaichien
force-pushed
the
export-D82254334
branch
from
31e97b6 to
a6f394f
Compare
Summary: After reviewing the feasibility of adding new Runtime functionality, we realized the current state of `Runtime` makes it hard/inconvenient to add new basic functionality. It requires creating a new interface (e.g. `IRuntime2`) to declare the new APIs. Then, everywhere it is needed, both the original `Runtime` and `IRuntime2` needs to passed in to access both APIs. After discussion, we decided to introduce `IRuntime`, which will declare most of the `Runtime` functionalities. All "protected" APIs, which made sense before interfaces were introduced, will now be public. The protected static methods of `Runtime` will remain as is for the Friends to access. After we decided to cut "stable" (after incoming JSI improvements), new functionalities will be added in `IRuntime2` interface. `IRuntime2` will inherit `IRuntime` to make existing functionality easy to access. Differential Revision: D89093651
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Changelog: [Internal] Differential Revision: D82254334
tsaichien
force-pushed
the
export-D82254334
branch
from
a6f394f to
f7224f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, the size of a jsi
Arrayis immutable. Once theArrayiscreated, users can only set the element at an existing index, but not
append to it.
This change adds an
Array::pushAPI to improve ergonomics.Changelog: [Internal]
Differential Revision: D82254334