RNGP - Fix build failures encounted with AGP 9.0.0-alpha05#53778
RNGP - Fix build failures encounted with AGP 9.0.0-alpha05#53778cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555. |
381f526 to
59807f7
Compare
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555. |
59807f7 to
af94db8
Compare
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555. |
af94db8 to
8eb30d4
Compare
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555. |
8eb30d4 to
6289e4b
Compare
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555. |
85d4e93 to
56c4a1c
Compare
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555. |
1 similar comment
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555. |
56c4a1c to
f6ea599
Compare
f6ea599 to
de5867f
Compare
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82452555. |
8ce9f40 to
55d4dc5
Compare
55d4dc5 to
03515e3
Compare
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82452555. |
03515e3 to
6f2ff59
Compare
…acebook#53778) Summary: I've been looking into the next major bump of AGP to 9: https://developer.android.com/build/releases/agp-preview#android-gradle-plugin-built-in-kotlin This change adapts our project so that it keeps on buildign with AGP 8 (as the bump to 9 would be a breaking change), but it addresses some of the build failures we'll be having with AGP 9: - Set `resValues` build option to true (default was changed true -> false in AGP 9) - Opts out our project from `android.builtInKotlin` and `android.newDsl` for the time being. Changelog: [Android] [Fixed] - Fix build failures with RNGP due to AGP 9.0.0-alpha05 Reviewed By: alanleedev Differential Revision: D82452555
6f2ff59 to
f1253b3
Compare
|
This pull request has been merged in 69dc655. |
|
This pull request was successfully merged by @cortinico in 69dc655 When will my fix make it into a release? | How to file a pick request? |
Summary:
I've been looking into the next major bump of AGP to 9:
https://developer.android.com/build/releases/agp-preview#android-gradle-plugin-built-in-kotlin
This change adapts our project so that it keeps on buildign with AGP 8
(as the bump to 9 would be a breaking change), but it addresses some of the build
failures we'll be having with AGP 9:
resValuesbuild option to true (default was changed true -> false in AGP 9)proguard-android-optimize.txt(this is now required in AGP 9)android.builtInKotlinandandroid.newDslfor the time being.Changelog:
[Android] [Fixed] - Fix build failures with RNGP due to AGP 9.0.0-alpha05
Differential Revision: D82452555