Skip to content

RNGP - Fix build failures encounted with AGP 9.0.0-alpha05#53778

Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico:export-D82452555
Closed

RNGP - Fix build failures encounted with AGP 9.0.0-alpha05#53778
cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico:export-D82452555

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
I've been looking into the next major bump of AGP to 9:
https://developer.android.com/build/releases/agp-preview#android-gradle-plugin-built-in-kotlin

This change adapts our project so that it keeps on buildign with AGP 8
(as the bump to 9 would be a breaking change), but it addresses some of the build
failures we'll be having with AGP 9:

  • Set resValues build option to true (default was changed true -> false in AGP 9)
  • Configures RNTester and Helloworld to use proguard-android-optimize.txt (this is now required in AGP 9)
  • Opts out our project from android.builtInKotlin and android.newDsl for the time being.

Changelog:
[Android] [Fixed] - Fix build failures with RNGP due to AGP 9.0.0-alpha05

Differential Revision: D82452555

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555.

@cortinico cortinico force-pushed the export-D82452555 branch 2 times, most recently from 85d4e93 to 56c4a1c Compare September 18, 2025 17:55
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555.

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82452555.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82452555.

@cortinico cortinico force-pushed the export-D82452555 branch 2 times, most recently from 8ce9f40 to 55d4dc5 Compare October 1, 2025 13:43
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Oct 10, 2025

@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82452555.

…acebook#53778)

Summary:

I've been looking into the next major bump of AGP to 9:
https://developer.android.com/build/releases/agp-preview#android-gradle-plugin-built-in-kotlin

This change adapts our project so that it keeps on buildign with AGP 8
(as the bump to 9 would be a breaking change), but it addresses some of the build
failures we'll be having with AGP 9:

- Set `resValues` build option to true (default was changed true -> false in AGP 9)
- Opts out our project from `android.builtInKotlin` and `android.newDsl` for the time being.

Changelog:
[Android] [Fixed] - Fix build failures with RNGP due to AGP 9.0.0-alpha05

Reviewed By: alanleedev

Differential Revision: D82452555
@meta-codesync meta-codesync Bot closed this in 69dc655 Oct 14, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 14, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Oct 14, 2025

This pull request has been merged in 69dc655.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 69dc655

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants