Skip to content

Turn on enableSwiftUIBasedFilters in the experimental channel #53794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 1 commit into from
Closed

Turn on enableSwiftUIBasedFilters in the experimental channel #53794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...eact/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Experimental_Android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<4feeb3c1789d8169dd93bee7ae1ff1ac>>
* @generated SignedSource<<dffc5db0f80501f6246f9d6087c6fb4a>>
*/

/**
Expand All @@ -25,5 +25,7 @@ public open class ReactNativeFeatureFlagsOverrides_RNOSS_Experimental_Android :

override fun enableAccessibilityOrder(): Boolean = true

override fun enableSwiftUIBasedFilters(): Boolean = true

override fun preventShadowTreeCommitExhaustion(): Boolean = true
}
6 changes: 5 additions & 1 deletion ...t-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSExperimental.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77870f0db494c7b6932950a1fa475fdc>>
* @generated SignedSource<<c5b1dc86ec11d40e5d26ae8a6f0ee6ff>>
*/

/**
Expand All @@ -31,6 +31,10 @@ class ReactNativeFeatureFlagsOverridesOSSExperimental : public ReactNativeFeatur
return true;
}

bool enableSwiftUIBasedFilters() override {
return true;
}

bool preventShadowTreeCommitExhaustion() override {
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ const definitions: FeatureFlagDefinitions = {
expectedReleaseValue: true,
purpose: 'experimentation',
},
ossReleaseStage: 'none',
ossReleaseStage: 'experimental',
},
enableViewCulling: {
defaultValue: false,
Expand Down