Fix scrollview overflow prop not set with Props 2.0#53871
Closed
lenaic wants to merge 1 commit into
Closed
Conversation
Summary: The props defined in `YogaStylableProps` define the overflow to be set to `Overflow::Visible` by default. The scroll view initialized the overflow setting to `Overflow.SCROLL`. This meant that Props 2.0 would only set the overflow prop if it was different from Visible, leading to the scroll view not being configured correctly when asking for the overflow to be visible. This diff assigns the correct initial value to the scrollview overflow setting only when enabling Props 2.0 to avoid any unexpected behavior changes when not using Props 2.0. Changelog: [Internal] Differential Revision: D82919286
meta-cla
Bot
added
the
CLA Signed
Contributor
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Sep 21, 2025
Summary: The props defined in `YogaStylableProps` define the overflow to be set to `Overflow::Visible` by default. The scroll view initialized the overflow setting to `Overflow.SCROLL`. This meant that Props 2.0 would only set the overflow prop if it was different from Visible, leading to the scroll view not being configured correctly when asking for the overflow to be visible. This diff assigns the correct initial value to the scrollview overflow setting only when enabling Props 2.0 to avoid any unexpected behavior changes when not using Props 2.0. Changelog: [Internal] Differential Revision: D82919286
Contributor
|
This pull request has been merged in e314f61. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in e314f61 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The props defined in
YogaStylablePropsdefine the overflow to be set toOverflow::Visibleby default.The scroll view initialized the overflow setting to
Overflow.SCROLL. This meant that Props 2.0 would only set the overflow prop if it was different from Visible, leading to the scroll view not being configured correctly when asking for the overflow to be visible.This diff assigns the correct initial value to the scrollview overflow setting only when enabling Props 2.0 to avoid any unexpected behavior changes when not using Props 2.0.
Changelog: [Internal]
Differential Revision: D82919286