remove connection hints from being logged for the user#53884
Closed
vzaidman wants to merge 3 commits into
Closed
Conversation
…ook#53846) Summary: Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS iOS has a colorful "Refreshing..." banner: {F1982086204} While android doesn't respect the color HMR asks it to set up for the banner: {F1982086218} Reviewed By: cortinico Differential Revision: D82726743
Summary: Changelog: [General][Added] - new banner added to indicate that Fast Refresh has lost connection, and that the app needs to be restarted to reconnect When HMR were getting disconnected, we were not giving any indication for the user. This lead to situations were the connection is re-established, but HMR is still disconnected, which is unexpected for users. Instead, raise a banner hinting the user to reload the app to reconnect. Reviewed By: huntie Differential Revision: D82726853
Summary: Changelog: [General][Internal] Don't display connection hints in Metro Now that there's a clear display for when HMR is disconnected, we don't want to show messages regardless devices connection and disconnection to the DevServer because they are too partial. Reviewed By: huntie Differential Revision: D82727105
meta-cla
Bot
added
the
CLA Signed
Contributor
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Sep 22, 2025
Summary: Changelog: [Internal] Now that there's a clear display for when HMR is disconnected, we don't want to show messages regardless devices connection and disconnection to the DevServer because they are too partial. Reviewed By: huntie Differential Revision: D82727105
Contributor
|
This pull request has been merged in e3bf881. |
Collaborator
|
This pull request was successfully merged by @vzaidman in e3bf881 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Now that there's a clear display for when HMR is disconnected, we don't want to show messages regardless devices connection and disconnection to the DevServer because they are too partial.
Changelog: [Internal]
Reviewed By: huntie
Differential Revision: D82727105