Implement saved window positioning per target#53910
Closed
huntie wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
Summary: NOTE: Resubmission of D82236159 — The `electron-store` dependency is now replaced with a local implementation. As titled. A long awaited quality of life improvement that we can now deliver with our desktop shell. Window arrangements are saved per [`windowKey`](https://github.com/facebook/react-native/blob/da7bf9c54567aae62ff355b79e66f511cb382065/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js#L193), mapping to each previously opened debugger target. **Limitations** - Does not save/restore macOS fullscreen app state. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D83070252
huntie
force-pushed
the
export-D83070252
branch
from
56c5bf2 to
65b1bb9
Compare
Contributor
Contributor
|
This pull request has been merged in 8027067. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Note
Resubmission of #53743 — The
electron-storedependency is now replaced with a local implementation.As titled. A long awaited quality of life improvement that we can now deliver with our desktop shell.
Window arrangements are saved per
windowKey, mapping to each previously opened debugger target.Limitations
Changelog: [Internal]
Differential Revision: D83070252