Control trait::hidden support through feature flag#54112
Closed
lenaic wants to merge 1 commit intofacebook:mainfrom
Closed
Control trait::hidden support through feature flag#54112lenaic wants to merge 1 commit intofacebook:mainfrom
lenaic wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: This diff adds the possibility to control the use of `Trait::Hidden` on Android platforms through feature flags. The feature flag is Android specific and only accessed on Android platforms. Changelog: [Internal] Differential Revision: D84289662
meta-cla
Bot
added
the
CLA Signed
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Oct 9, 2025
Summary: This diff adds the possibility to control the use of `Trait::Hidden` on Android platforms through feature flags. The feature flag is Android specific and only accessed on Android platforms. Changelog: [Internal] Differential Revision: D84289662
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Oct 10, 2025
Summary: This diff adds the possibility to control the use of `Trait::Hidden` on Android platforms through feature flags. The feature flag is Android specific and only accessed on Android platforms. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D84289662
|
This pull request has been merged in 8d245e9. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in 8d245e9 When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 28, 2026
SudoPlz
added a commit
to SudoPlz/react-native
that referenced
this pull request
Apr 29, 2026
Mirrors useTraitHiddenOnAndroid (facebook#54112) on iOS so apps can opt out of the `Trait::Hidden` slice-skip optimization in sliceChildShadowNodeViewPairs. When the flag is `false`, Hidden subtrees remain in the mount slice and are hidden via `UIView.hidden = YES` through the existing UIView+ComponentViewProtocol path (D8460108, 2018) instead of being torn down via REMOVE + DELETE. Default `true` so iOS behaviour is unchanged for everyone who doesn't override it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the possibility to control the use of
Trait::Hiddenon Android platforms through feature flags. The feature flag is Android specific and only accessed on Android platforms.Changelog: [Internal]
Differential Revision: D84289662