Fix RCTDevLoadingView banner interaction #54706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…54702) Summary: Changelog: [iOS][Fixed] - Make rest of app responsive whilst dev loading banner present The dev loading banner window was previously full-screen height, making the entire screen unresponsive to touches even though only a small banner was visible. The window frame is now calculated after Auto Layout completes, ensuring it matches the actual content height (label + padding + safe area). This allows the rest of the screen below the banner to remain interactive. The banner now only blocks interactions within its actual bounds Reviewed By: vzaidman Differential Revision: D87922708
Summary: Changelog: [iOS][Fixed] - remove redundant gesture to tap button when the layer beneath is already tappable The dismiss button had a redundant tap handler when the entire banner was already tappable. **Redundant button interaction**: The dismiss button's `primaryAction` was removed and `userInteractionEnabled` is set to `NO`, making it purely visual. Taps on the button now pass through to the banner's tap gesture recognizer. Reviewed By: vzaidman Differential Revision: D87927449
meta-cla
bot
added
the
CLA Signed
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87927449. |
|
This pull request has been merged in 8b8ccea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[iOS][Fixed] - remove redundant gesture to tap button when the layer beneath is already tappable
The dismiss button had a redundant tap handler when the entire banner was already tappable.
Redundant button interaction: The dismiss button's
primaryActionwas removed anduserInteractionEnabledis set toNO, making it purely visual. Taps on the button now pass through to the banner's tap gesture recognizer.Reviewed By: vzaidman
Differential Revision: D87927449