Add option to trigger the backend from events #54899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89286813. |
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: facebook#54899 Currently the backend only applies changes when it is notified of a new animation frame. This setup doesn't work properly for events, as they could come in after the current frame was already calculated. So we need to allow events to trigger the backend manually. Differential Revision: D89286813
bartlomiejbloniarz
force-pushed
the
export-D89286813
branch
from
1771c26 to
68fb734
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: facebook#54899 Currently the backend only applies changes when it is notified of a new animation frame. This setup doesn't work properly for events, as they could come in after the current frame was already calculated. So we need to allow events to trigger the backend manually. Differential Revision: D89286813
bartlomiejbloniarz
force-pushed
the
export-D89286813
branch
2 times, most recently
from
6f46eea to
8944b0c
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: facebook#54899 Currently the backend only applies changes when it is notified of a new animation frame. This setup doesn't work properly for events, as they could come in after the current frame was already calculated. So we need to allow events to trigger the backend manually. Differential Revision: D89286813
Collaborator
|
bartlomiejbloniarz
force-pushed
the
export-D89286813
branch
from
8944b0c to
d98e3bf
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 17, 2025
Summary: Pull Request resolved: facebook#54899 Currently the backend only applies changes when it is notified of a new animation frame. This setup doesn't work properly for events, as they could come in after the current frame was already calculated. So we need to allow events to trigger the backend manually. Differential Revision: D89286813
bartlomiejbloniarz
force-pushed
the
export-D89286813
branch
from
d98e3bf to
c345fae
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 18, 2025
Summary: Pull Request resolved: facebook#54899 Currently the backend only applies changes when it is notified of a new animation frame. This setup doesn't work properly for events, as they could come in after the current frame was already calculated. So we need to allow events to trigger the backend manually. Differential Revision: D89286813
bartlomiejbloniarz
force-pushed
the
export-D89286813
branch
from
c345fae to
800f741
Compare
bartlomiejbloniarz
pushed a commit
to bartlomiejbloniarz/react-native
that referenced
this pull request
Dec 19, 2025
Summary: Pull Request resolved: facebook#54899 Currently the backend only applies changes when it is notified of a new animation frame. This setup doesn't work properly for events, as they could come in after the current frame was already calculated. So we need to allow events to trigger the backend manually. Differential Revision: D89286813
added 3 commits
January 7, 2026 01:29
Summary: Pull Request resolved: facebook#54879 This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup `tagToShadowNodeFamily_` when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that. Differential Revision: D89042963
Summary: Pull Request resolved: facebook#54877 This diff adds synchronizing props to react, through a scheduled commit on the js thread. This is used by animated at the end of the animation, and leverages RSNRU to actually push the update to reactjs. Differential Revision: D89042949
Summary: Pull Request resolved: facebook#54899 Currently the backend only applies changes when it is notified of a new animation frame. This setup doesn't work properly for events, as they could come in after the current frame was already calculated. So we need to allow events to trigger the backend manually. Reviewed By: zeyap Differential Revision: D89286813
bartlomiejbloniarz
force-pushed
the
export-D89286813
branch
from
800f741 to
5c79c1e
Compare
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in ac06f3b When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in ac06f3b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently the backend only applies changes when it is notified of a new animation frame. This setup doesn't work properly for events, as they could come in after the current frame was already calculated. So we need to allow events to trigger the backend manually.
Differential Revision: D89286813