Skip to content

[ios] Fix regression stopping --project-directory from working #55204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kitten wants to merge 2 commits into from
Closed

[ios] Fix regression stopping --project-directory from working #55204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e31a4e
Construct `react_native_path` from installation root instead
kitten Jan 16, 2026
47e76db
Update remaining relative path for clarity
kitten Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-native/scripts/react_native_pods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def use_react_native! (
error_if_try_to_use_jsc_from_core()
warn_if_new_arch_disabled()

react_native_path = Pathname.pwd.join(path)
react_native_path = Pod::Config.instance.installation_root.join(path)
prefix = react_native_path.relative_path_from(Pod::Config.instance.installation_root)

hermes_enabled= true
Expand Down Expand Up @@ -106,7 +106,7 @@ def use_react_native! (
# that has invoked the `use_react_native!` function.
ReactNativePodsUtils.detect_use_frameworks(current_target_definition)

CodegenUtils.clean_up_build_folder(path, $CODEGEN_OUTPUT_DIR)
CodegenUtils.clean_up_build_folder(react_native_path, $CODEGEN_OUTPUT_DIR)
Copy link
Contributor Author

@kitten kitten Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I updated for clarity. Without this, if path isn't relative to the pwd the FileUtils.rm_rf can silently fail here afaict:

react-native/packages/react-native/scripts/cocoapods/codegen_utils.rb

Lines 91 to 93 in 9d3cc38

base_provider_path = file_manager.join(rn_path, 'React', 'Fabric', 'RCTThirdPartyFabricComponentsProvider')
FileUtils.rm_rf("#{base_provider_path}.h")
FileUtils.rm_rf("#{base_provider_path}.mm")


# We are relying on this flag also in third parties libraries to proper install dependencies.
# Better to rely and enable this environment flag if the new architecture is turned on using flags.
Expand Down
Loading