[ios] Fix regression stopping --project-directory from working

[kitten]

Summary:

This is a fix for a regression in #54948 found by @Kudo. Passing an absolute path for react_native_path was non-functional before and the change was meant to fix this.

This however used Pathname.pwd.join(path) since I assumed that'd be the intention for a relative path. However, my assumption was that pod install would only ever be run in the installation root and hence be equivalent to Pod::Config.instance.installation_root most of the time.

This broke: pod install --project-directory ios (and the likes), since I wasn't aware of the --project-directory argument before.

To fix this, we should construct the absolute path and join from Pod::Config.instance.installation_root as well.

Note to self: Needs a pick into 0.84.0 due to being a regression (will file a pick request after this is merged)

Changelog:

[IOS] [FIXED] Regression from #54948 preventing pod install --project-directory from working properly

Test Plan:

• Run pod install in rn-tester to validate

[kitten]

This is something I updated for clarity. Without this, if path isn't relative to the pwd the FileUtils.rm_rf can silently fail here afaict:

react-native/packages/react-native/scripts/cocoapods/codegen_utils.rb

Lines 91 to 93 in 9d3cc38

	base_provider_path = file_manager.join(rn_path, 'React', 'Fabric', 'RCTThirdPartyFabricComponentsProvider')
	FileUtils.rm_rf("#{base_provider_path}.h")
	FileUtils.rm_rf("#{base_provider_path}.mm")

[cipolleschi]

Thanks for the fix

[meta-codesync]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D90870064.

[react-native-bot]

This pull request was successfully merged by @kitten in 9f686f2

^{When will my fix make it into a release? | How to file a pick request?}