fix(android): Image `defaultSource` & `loadingIndicatorSrc` broken with props 2.0 #55210

hannojg · 2026-01-16T16:19:53Z

Summary:

Fixes crashes using component on android with props 2.0 enabled using feature flag:

enablePropsUpdateReconciliationAndroid

Crash stack

Error while updating prop source
java.lang.reflect.InvocationTargetException
	at java.lang.reflect.Method.invoke(Native Method)
	at G0.a.q(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:89)
	at com.facebook.react.uimanager.ViewManager.updateProperties(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:33)
	at com.facebook.react.uimanager.ViewManager.createViewInstance(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:12)
	at com.facebook.react.uimanager.ViewManager.createView(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1)
	at q1.h.b(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:62)
	at r1.g.execute(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:67)
	at q1.b.d(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:71)
	at q1.b.c(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:64)
	at m1.j.a(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:100)
	at com.facebook.react.uimanager.d.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1)
	at E1.o.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:98)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2457)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2468)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1693)
	at android.view.Choreographer.doAnimationLoad(Choreographer.java:1523)
	at android.view.Choreographer.doFrame(Choreographer.java:1438)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2284)
	at android.os.Handler.handleCallback(Handler.java:1014)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loopOnce(Looper.java:250)
	at android.os.Looper.loop(Looper.java:340)
	at android.app.ActivityThread.main(ActivityThread.java:9911)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:621)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957)
Caused by: com.facebook.react.bridge.NoSuchKeyException: width
	at com.facebook.react.bridge.ReadableNativeMap.getValue(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:3)
	at com.facebook.react.bridge.ReadableNativeMap.getDouble(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:6)
	at r2.l.setSource(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:143)
	at com.facebook.react.views.image.ReactImageManager.setSource(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:6)
	at java.lang.reflect.Method.invoke(Native Method) 
	at G0.a.q(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:89) 
	at com.facebook.react.uimanager.ViewManager.updateProperties(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:33) 
	at com.facebook.react.uimanager.ViewManager.createViewInstance(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:12) 
	at com.facebook.react.uimanager.ViewManager.createView(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at q1.h.b(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:62) 
	at r1.g.execute(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:67) 
	at q1.b.d(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:71) 
	at q1.b.c(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:64) 
	at m1.j.a(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:100) 
	at com.facebook.react.uimanager.d.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at E1.o.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:98) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2457) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2468) 
	at android.view.Choreographer.doCallbacks(Choreographer.java:1693) 
	at android.view.Choreographer.doAnimationLoad(Choreographer.java:1523) 
	at android.view.Choreographer.doFrame(Choreographer.java:1438) 
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2284) 
	at android.os.Handler.handleCallback(Handler.java:1014) 
	at android.os.Handler.dispatchMessage(Handler.java:102) 
	at android.os.Looper.loopOnce(Looper.java:250) 
	at android.os.Looper.loop(Looper.java:340) 
	at android.app.ActivityThread.main(ActivityThread.java:9911) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:621) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957) 
Exception thrown when executing UIFrameGuarded
com.facebook.react.bridge.JSApplicationIllegalArgumentException: Error while updating property 'source' of a view managed by: RCTImageView
	at G0.a.q(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:144)
	at com.facebook.react.uimanager.ViewManager.updateProperties(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:33)
	at com.facebook.react.uimanager.ViewManager.createViewInstance(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:12)
	at com.facebook.react.uimanager.ViewManager.createView(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1)
	at q1.h.b(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:62)
	at r1.g.execute(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:67)
	at q1.b.d(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:71)
	at q1.b.c(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:64)
	at m1.j.a(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:100)
	at com.facebook.react.uimanager.d.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1)
	at E1.o.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:98)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2457)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2468)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1693)
	at android.view.Choreographer.doAnimationLoad(Choreographer.java:1523)
	at android.view.Choreographer.doFrame(Choreographer.java:1438)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2284)
	at android.os.Handler.handleCallback(Handler.java:1014)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loopOnce(Looper.java:250)
	at android.os.Looper.loop(Looper.java:340)
	at android.app.ActivityThread.main(ActivityThread.java:9911)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:621)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957)
Caused by: java.lang.reflect.InvocationTargetException
	at java.lang.reflect.Method.invoke(Native Method)
	at G0.a.q(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:89)
	at com.facebook.react.uimanager.ViewManager.updateProperties(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:33) 
	at com.facebook.react.uimanager.ViewManager.createViewInstance(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:12) 
	at com.facebook.react.uimanager.ViewManager.createView(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at q1.h.b(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:62) 
	at r1.g.execute(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:67) 
	at q1.b.d(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:71) 
	at q1.b.c(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:64) 
	at m1.j.a(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:100) 
	at com.facebook.react.uimanager.d.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at E1.o.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:98) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2457) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2468) 
	at android.view.Choreographer.doCallbacks(Choreographer.java:1693) 
	at android.view.Choreographer.doAnimationLoad(Choreographer.java:1523) 
	at android.view.Choreographer.doFrame(Choreographer.java:1438) 
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2284) 
	at android.os.Handler.handleCallback(Handler.java:1014) 
	at android.os.Handler.dispatchMessage(Handler.java:102) 
	at android.os.Looper.loopOnce(Looper.java:250) 
	at android.os.Looper.loop(Looper.java:340) 
	at android.app.ActivityThread.main(ActivityThread.java:9911) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:621) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957) 
Caused by: com.facebook.react.bridge.NoSuchKeyException: width
	at com.facebook.react.bridge.ReadableNativeMap.getValue(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:3)
	at com.facebook.react.bridge.ReadableNativeMap.getDouble(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:6)
	at r2.l.setSource(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:143)
	at com.facebook.react.views.image.ReactImageManager.setSource(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:6)
	at java.lang.reflect.Method.invoke(Native Method) 
	at G0.a.q(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:89) 
	at com.facebook.react.uimanager.ViewManager.updateProperties(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:33) 
	at com.facebook.react.uimanager.ViewManager.createViewInstance(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:12) 
	at com.facebook.react.uimanager.ViewManager.createView(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at q1.h.b(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:62) 
	at r1.g.execute(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:67) 
	at q1.b.d(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:71) 
	at q1.b.c(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:64) 
	at m1.j.a(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:100) 
	at com.facebook.react.uimanager.d.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at E1.o.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:98) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2457) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2468) 
	at android.view.Choreographer.doCallbacks(Choreographer.java:1693) 
	at android.view.Choreographer.doAnimationLoad(Choreographer.java:1523) 
	at android.view.Choreographer.doFrame(Choreographer.java:1438) 
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2284) 
	at android.os.Handler.handleCallback(Handler.java:1014) 
	at android.os.Handler.dispatchMessage(Handler.java:102) 
	at android.os.Looper.loopOnce(Looper.java:250) 
	at android.os.Looper.loop(Looper.java:340) 
	at android.app.ActivityThread.main(ActivityThread.java:9911) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:621) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957) 
ReactHost{0}.handleHostException(message = "Error while updating property 'source' of a view managed by: RCTImageView")
Shutting down VM
FATAL EXCEPTION: main
Process: com.facebook.react.uiapp, PID: 23676
com.facebook.react.bridge.JSApplicationIllegalArgumentException: Error while updating property 'source' of a view managed by: RCTImageView
	at G0.a.q(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:144)
	at com.facebook.react.uimanager.ViewManager.updateProperties(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:33)
	at com.facebook.react.uimanager.ViewManager.createViewInstance(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:12)
	at com.facebook.react.uimanager.ViewManager.createView(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1)
	at q1.h.b(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:62)
	at r1.g.execute(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:67)
	at q1.b.d(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:71)
	at q1.b.c(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:64)
	at m1.j.a(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:100)
	at com.facebook.react.uimanager.d.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1)
	at E1.o.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:98)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2457)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2468)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1693)
	at android.view.Choreographer.doAnimationLoad(Choreographer.java:1523)
	at android.view.Choreographer.doFrame(Choreographer.java:1438)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2284)
	at android.os.Handler.handleCallback(Handler.java:1014)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loopOnce(Looper.java:250)
	at android.os.Looper.loop(Looper.java:340)
	at android.app.ActivityThread.main(ActivityThread.java:9911)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:621)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957)
Caused by: java.lang.reflect.InvocationTargetException
	at java.lang.reflect.Method.invoke(Native Method)
	at G0.a.q(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:89)
	at com.facebook.react.uimanager.ViewManager.updateProperties(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:33) 
	at com.facebook.react.uimanager.ViewManager.createViewInstance(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:12) 
	at com.facebook.react.uimanager.ViewManager.createView(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at q1.h.b(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:62) 
	at r1.g.execute(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:67) 
	at q1.b.d(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:71) 
	at q1.b.c(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:64) 
	at m1.j.a(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:100) 
	at com.facebook.react.uimanager.d.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at E1.o.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:98) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2457) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2468) 
	at android.view.Choreographer.doCallbacks(Choreographer.java:1693) 
	at android.view.Choreographer.doAnimationLoad(Choreographer.java:1523) 
	at android.view.Choreographer.doFrame(Choreographer.java:1438) 
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2284) 
	at android.os.Handler.handleCallback(Handler.java:1014) 
	at android.os.Handler.dispatchMessage(Handler.java:102) 
	at android.os.Looper.loopOnce(Looper.java:250) 
	at android.os.Looper.loop(Looper.java:340) 
	at android.app.ActivityThread.main(ActivityThread.java:9911) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:621) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957) 
Caused by: com.facebook.react.bridge.NoSuchKeyException: width
	at com.facebook.react.bridge.ReadableNativeMap.getValue(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:3)
	at com.facebook.react.bridge.ReadableNativeMap.getDouble(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:6)
	at r2.l.setSource(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:143)
	at com.facebook.react.views.image.ReactImageManager.setSource(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:6)
	at java.lang.reflect.Method.invoke(Native Method) 
	at G0.a.q(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:89) 
	at com.facebook.react.uimanager.ViewManager.updateProperties(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:33) 
	at com.facebook.react.uimanager.ViewManager.createViewInstance(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:12) 
	at com.facebook.react.uimanager.ViewManager.createView(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at q1.h.b(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:62) 
	at r1.g.execute(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:67) 
	at q1.b.d(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:71) 
	at q1.b.c(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:64) 
	at m1.j.a(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:100) 
	at com.facebook.react.uimanager.d.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:1) 
	at E1.o.doFrame(r8-map-id-1a92cc952529f7daea85f71c4ad30656f52b60c3e338ced74ff1293d461ae7b1:98) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2457) 
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2468) 
	at android.view.Choreographer.doCallbacks(Choreographer.java:1693) 
	at android.view.Choreographer.doAnimationLoad(Choreographer.java:1523) 
	at android.view.Choreographer.doFrame(Choreographer.java:1438) 
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2284) 
	at android.os.Handler.handleCallback(Handler.java:1014) 
	at android.os.Handler.dispatchMessage(Handler.java:102) 
	at android.os.Looper.loopOnce(Looper.java:250) 
	at android.os.Looper.loop(Looper.java:340) 
	at android.app.ActivityThread.main(ActivityThread.java:9911) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:621) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957)

On android we pass the defaultSource and loadingIndicatorSrc as strings. however, when enabling prop diffing this causes crashes, as the prop diff mechanism is parsing them to ImageSource as defined in ImageProps.h.

W/o props 2.0 diffing we simply return the props as we receive them from JS (with those sources as string):

react-native/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp

Line 341 in c12806c

return ReadableNativeMap::newObjectCxxArgs(newProps->rawProps);

With props diffing …

react-native/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp

Line 309 in c12806c

auto diff = newProps->getDiffProps(oldProps);

… We actually transform them to the c++ object:

react-native/packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.cpp

Lines 210 to 215 in c12806c

    
           if (defaultSource != oldProps->defaultSource) { 
        
             result["defaultSource"] = toDynamic(defaultSource); 
        
           } 
        
           if (loadingIndicatorSource != oldProps->loadingIndicatorSource) { 
        
             result["loadingIndicatorSource"] = toDynamic(loadingIndicatorSource);

react-native/packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.h

Lines 29 to 30 in c12806c

    
           ImageSource defaultSource{}; 
        
           ImageSource loadingIndicatorSource{};

react-native/packages/react-native/ReactCommon/react/renderer/imagemanager/primitives.h

Lines 47 to 74 in c12806c

    
           #ifdef RN_SERIALIZABLE_STATE 
        
             folly::dynamic toDynamic() const 
        
             { 
        
               folly::dynamic imageSourceResult = folly::dynamic::object(); 
        
               switch (type) { 
        
                 case ImageSource::Type::Remote: 
        
                   imageSourceResult["type"] = "remote"; 
        
                   break; 
        
                 case ImageSource::Type::Local: 
        
                   imageSourceResult["type"] = "local"; 
        
                   break; 
        
                 case ImageSource::Type::Invalid: 
        
                 default: 
        
                   imageSourceResult["type"] = "invalid"; 
        
                   break; 
        
               } 
        
               imageSourceResult["uri"] = uri; 
        
               imageSourceResult["bundle"] = bundle; 
        
               imageSourceResult["scale"] = scale; 
        
               folly::dynamic sizeResult = folly::dynamic::object(); 
        
               sizeResult["width"] = size.width; 
        
               sizeResult["height"] = size.height; 
        
               imageSourceResult["size"] = sizeResult; 
        
               imageSourceResult["body"] = body; 
        
               imageSourceResult["method"] = method;

This throws errors and crashes the app:

Screen.Recording.2026-01-19.at.19.42.05.mov

I think the proper solution here is to pass the full objects down, with or without props 2.0 diffing and handle the objects in native code correctly. This way android aligns with the iOS implementation too.

Changelog:

[ANDROID] [FIXED] - fixed defaultSource and loadingIndicatorSrc causing a crash when enablePropsUpdateReconciliationAndroid is enabled
[ANDROID] [BREAKING] - Changed ReactImageView#setDefaultSource(String?) to ReactImageView#setDefaultSource(ReadableMap?)
[ANDROID] [BREAKING] - Changed ReactImageView#setLoadingIndicatorSource(String?) to ReactImageView#setLoadingIndicatorSource(ReadableMap?)

Test Plan:

Test that the defaultProp example in RNTester is working
Enable props 2.0 diffing mechanism:

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt
index bb0a6b525da..04fcbf4ba8f 100644
--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt
+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt
@@ -11,4 +11,8 @@ public class ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android() :
     ReactNativeNewArchitectureFeatureFlagsDefaults() {
 
   override fun useFabricInterop(): Boolean = true
+
+  override fun enableAccumulatedUpdatesInRawPropsAndroid(): Boolean = true
+  override fun enablePropsUpdateReconciliationAndroid(): Boolean = true
+  override fun enableExclusivePropsUpdateAndroid(): Boolean = true
 }

Test all image examples:
- Verify there is no crash
- Verify defaultSource example is working

Recordings:

Debug	Release
debug.mov	release.mov

Note: this uses the example setup from this PR in the recordings:

example(android): show default source image example #55234

…e` & `loadingIndicatorSrc`

this is needed on ios but not android

local image is now referenced correctly as local

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2026

hannojg force-pushed the fix/android-diffprops-image-source-broken branch 2 times, most recently from cd67404 to 8194e3d Compare January 19, 2026 18:46

hannojg marked this pull request as ready for review January 19, 2026 18:47

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 19, 2026

hannojg mentioned this pull request Jan 20, 2026

example(android): show default source image example #55234

Open

hannojg added 7 commits January 20, 2026 10:04

fix(android): pass full image object to native side for `defaultSourc…

7c15762

…e` & `loadingIndicatorSrc`

fix(android): image w&h are not to be wrapped in size

6f3e8d9

this is needed on ios but not android

fix setting default source

4a7f5c2

change to soft assertion to not break current API

22c7f86

cleanup

45a78ef

update flow type for loadingIndicatorSrc

0a78d96

update fantom test

985edfb

local image is now referenced correctly as local

hannojg force-pushed the fix/android-diffprops-image-source-broken branch from 8194e3d to 985edfb Compare January 20, 2026 09:12

remove console log

2d1b2f5

hannojg changed the title ~~fix(android): Image source & defaultSource broken with props 2.0~~ fix(android): Image defaultSource & loadingIndicatorSrc broken with props 2.0 Jan 20, 2026

hannojg changed the title ~~fix(android): Image defaultSource & loadingIndicatorSrc broken with props 2.0~~ fix(android): Image defaultSource & loadingIndicatorSrc broken with props 2.0 Jan 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(android): Image `defaultSource` & `loadingIndicatorSrc` broken with props 2.0 #55210

fix(android): Image `defaultSource` & `loadingIndicatorSrc` broken with props 2.0 #55210

hannojg commented Jan 16, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if (defaultSource != oldProps->defaultSource) {
	result["defaultSource"] = toDynamic(defaultSource);
	}

	if (loadingIndicatorSource != oldProps->loadingIndicatorSource) {
	result["loadingIndicatorSource"] = toDynamic(loadingIndicatorSource);

	ImageSource defaultSource{};
	ImageSource loadingIndicatorSource{};

	#ifdef RN_SERIALIZABLE_STATE
	folly::dynamic toDynamic() const
	{
	folly::dynamic imageSourceResult = folly::dynamic::object();
	switch (type) {
	case ImageSource::Type::Remote:
	imageSourceResult["type"] = "remote";
	break;
	case ImageSource::Type::Local:
	imageSourceResult["type"] = "local";
	break;
	case ImageSource::Type::Invalid:
	default:
	imageSourceResult["type"] = "invalid";
	break;
	}

	imageSourceResult["uri"] = uri;
	imageSourceResult["bundle"] = bundle;
	imageSourceResult["scale"] = scale;

	folly::dynamic sizeResult = folly::dynamic::object();
	sizeResult["width"] = size.width;
	sizeResult["height"] = size.height;
	imageSourceResult["size"] = sizeResult;

	imageSourceResult["body"] = body;
	imageSourceResult["method"] = method;

fix(android): Image defaultSource & loadingIndicatorSrc broken with props 2.0 #55210

Are you sure you want to change the base?

fix(android): Image defaultSource & loadingIndicatorSrc broken with props 2.0 #55210

Conversation

hannojg commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(android): Image `defaultSource` & `loadingIndicatorSrc` broken with props 2.0 #55210

fix(android): Image `defaultSource` & `loadingIndicatorSrc` broken with props 2.0 #55210

hannojg commented Jan 16, 2026 •

edited

Loading