Avoid repeated allocations in getChildOffsetRelativeToRoot#55274
Closed
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Closed
Avoid repeated allocations in getChildOffsetRelativeToRoot#55274fabriziocucci wants to merge 1 commit intofacebook:mainfrom
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91230611. |
…55274) Summary: Changelog: [Internal] Refactors `getChildOffsetRelativeToRoot()` to use a static `Rect` field instead of allocating a new `Rect` and `int[]` on every call. Since this is a private method, we can return the `Rect` directly to avoid the extra `int[]` allocation. This addresses the code review feedback on D90988373. Reviewed By: javache Differential Revision: D91230611
fabriziocucci
force-pushed
the
export-D91230611
branch
from
e3d3fb8 to
aacc645
Compare
|
This pull request has been merged in 490c5e8. |
Collaborator
|
This pull request was successfully merged by @fabriziocucci in 490c5e8 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Refactors
getChildOffsetRelativeToRoot()to use a staticRectfield instead of allocating a newRectandint[]on every call. Since this is a private method, we can return theRectdirectly to avoid the extraint[]allocation.This addresses the code review feedback on D90988373.
Differential Revision: D91230611