fix(codegen): add generateOptional(Object)Properties types to options#55311
Closed
hannojg wants to merge 1 commit intofacebook:mainfrom
Closed
fix(codegen): add generateOptional(Object)Properties types to options#55311hannojg wants to merge 1 commit intofacebook:mainfrom
generateOptional(Object)Properties types to options#55311hannojg wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
hannojg
changed the title
generateOptional(Object)Properties types to options
facebook-github-bot
added
the
Shared with Meta
cipolleschi
approved these changes
Jan 27, 2026
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D91580643. |
cortinico
approved these changes
Jan 27, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@cipolleschi merged this pull request in 4b8be1f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In this PR new options were introduced for codegen view components:
This PR exposes those options to typescript.
Changelog:
[INTERNAL] [ADDED] - Typescript definitions for new
codegenNativeComponentoptionsgenerateOptional(Object)PropertiesTest Plan: