Sync clipChildren with overflow: hidden#55368
Closed
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Closed
Sync clipChildren with overflow: hidden#55368fabriziocucci wants to merge 1 commit intofacebook:mainfrom
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91775635. |
fabriziocucci
force-pushed
the
export-D91775635
branch
from
0543944 to
8343c11
Compare
Summary: Changelog: [Internal] We found an issue (T253147322) in the LivingRoom top bar where a full-screen OCPanel within a parent with `overflow: hidden` occludes content outside the parent (see [code](https://www.internalfb.com/code/fbsource/[753feac76cb1]/arvr/js/apps/LivingRoom/src/ReactNative/App/HTV/Shared/Toolbar/LivingRoomToolbar.react.js?lines=85-96)). This change adds a feature flag `enableClipChildrenForOverflowHidden` that, when enabled, sets `clipChildren = true` whenever `overflow: hidden` is set. This makes `TouchTargetHelper` also reject touches on children outside the parent's bounds (see [code](https://www.internalfb.com/code/fbsource/[753feac76cb1]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/TouchTargetHelper.kt?lines=211-213)), aligning hit testing behavior with visual rendering. The fix is gated behind a feature flag to allow gradual rollout and prevent potential regressions in apps that may rely on the current behavior. Reviewed By: Abbondanzo Differential Revision: D91775635
fabriziocucci
force-pushed
the
export-D91775635
branch
from
8343c11 to
ac2d7e3
Compare
Collaborator
|
This pull request was successfully merged by @fabriziocucci in 1c8f297 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
We found an issue (T253147322) in the LivingRoom top bar where a full-screen OCPanel within a parent with
overflow: hiddenoccludes content outside the parent (see code).This change adds a feature flag
enableClipChildrenForOverflowHiddenthat, when enabled, setsclipChildren = truewheneveroverflow: hiddenis set. This makesTouchTargetHelperalso reject touches on children outside the parent's bounds (see code), aligning hit testing behavior with visual rendering.The fix is gated behind a feature flag to allow gradual rollout and prevent potential regressions in apps that may rely on the current behavior.
Reviewed By: Abbondanzo
Differential Revision: D91775635