Closed
Conversation
Summary: Add optional flag to JS build setup that includes running the `"prepack"` script step after build — allowing the net behaviour before facebook#54857 to be conveninently switched to if needed. This is motivated by fixing our internal CI action for `xplat/js/react-native-github/scripts/debugger-shell/build-binary.js` — which depends on a locally built + package.json-written package state (the latter of which no longer happened for `yarn build` by default). Changelog: [Internal] Differential Revision: D92395174
meta-cla
bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by @huntie in 141e021 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 141e021. |
fabriziocucci
added a commit
to fabriziocucci/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Changelog: [Internal] The build_debugger_shell CI job was failing because build-binary.js expects pkg.main to start with ./dist/, but without --prepack the prepack.js script never runs, so main stays as ./src/index.js. This was caused by a series of PRs: - PR facebook#54857 refactored debugger-shell/package.json to use the publishConfig pattern, moving main from ./dist/index.js to ./src/index.js. - PR facebook#55415 added the --prepack flag to build.js to support this. - PR facebook#55416 added the build_debugger_shell CI job but ran yarn build without --prepack. The fix passes --prepack to yarn build so that prepack.js rewrites package.json main to ./dist/index.js before build-binary.js runs. Reviewed By: huntie Differential Revision: D95818417
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: #56005 Changelog: [Internal] The build_debugger_shell CI job was failing because build-binary.js expects pkg.main to start with ./dist/, but without --prepack the prepack.js script never runs, so main stays as ./src/index.js. This was caused by a series of PRs: - PR #54857 refactored debugger-shell/package.json to use the publishConfig pattern, moving main from ./dist/index.js to ./src/index.js. - PR #55415 added the --prepack flag to build.js to support this. - PR #55416 added the build_debugger_shell CI job but ran yarn build without --prepack. The fix passes --prepack to yarn build so that prepack.js rewrites package.json main to ./dist/index.js before build-binary.js runs. Reviewed By: huntie Differential Revision: D95818417 fbshipit-source-id: 03c8340c415960c3937b13bdea3952798d2d420e
fabriziocucci
added a commit
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: #56005 Changelog: [Internal] The build_debugger_shell CI job was failing because build-binary.js expects pkg.main to start with ./dist/, but without --prepack the prepack.js script never runs, so main stays as ./src/index.js. This was caused by a series of PRs: - PR #54857 refactored debugger-shell/package.json to use the publishConfig pattern, moving main from ./dist/index.js to ./src/index.js. - PR #55415 added the --prepack flag to build.js to support this. - PR #55416 added the build_debugger_shell CI job but ran yarn build without --prepack. The fix passes --prepack to yarn build so that prepack.js rewrites package.json main to ./dist/index.js before build-binary.js runs. Reviewed By: huntie Differential Revision: D95818417 fbshipit-source-id: 03c8340c415960c3937b13bdea3952798d2d420e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add optional flag to JS build setup that includes running the
"prepack"script step after build — allowing the net behaviour before #54857 to be conveninently switched to if needed.This is motivated by fixing our internal CI action for
xplat/js/react-native-github/scripts/debugger-shell/build-binary.js— which depends on a locally built + package.json-written package state (the latter of which no longer happened foryarn buildby default).Changelog: [Internal]
Differential Revision: D92395174