Remove build package.json dirty state check#55420
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Remove build package.json dirty state check#55420huntie wants to merge 1 commit intofacebook:mainfrom
huntie wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: After facebook#54857 (use of the "publishConfig" field), this check is no longer necessary, since `yarn build` will no longer make changes to any checked in files. In the (expectedly) rare case that `yarn build --prepack` changes are committed (only intended for CI), Flow will also fail independently. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D92397786
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in a25049b. |
Collaborator
|
This pull request was successfully merged by @huntie in a25049b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After #54857 (use of the "publishConfig" field), this check is no longer necessary, since
yarn buildwill no longer make changes to any checked in files.In the (expectedly) rare case that
yarn build --prepackchanges are committed (only intended for CI), Flow will also fail independently.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D92397786