Closed
Conversation
meta-cla
bot
added
the
CLA Signed
Summary: Adds a `build_debugger_shell` job as part of the `test-all` workflow, adding missing coverage to `scripts/debugger-shell/build-binary.js`. This was broken recently by facebook#54857. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D92396626
Summary: Deletes the largely unused `analyze_code`/`code-analysis-bot` script, which was part of our earlier CircleCI infra. **Motivation** - **Security**: Removes another use of a `GITHUB_TOKEN` env var being loaded into a script in our CI (similar to S603729). - **Cleanup**: This script attempted to read various lint job results (including google-java-format, which is no longer present), and post a GitHub PR comment for >5 issues. In a GitHub Actions world, we don't really need this functionality. **Other changes** - The `yarn shellcheck` run from this script was load bearing, and is moved directly into the `lint` action. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D92407627
huntie
force-pushed
the
export-D92407627
branch
from
fb8c02f to
4a8d967
Compare
|
This pull request has been merged in 1930529. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Deletes the largely unused
analyze_code/code-analysis-botscript, which was part of our earlier CircleCI infra.Motivation
GITHUB_TOKENenv var being loaded into a script in our CI (similar to S603729).Other changes
yarn shellcheckrun from this script was load bearing, and is moved directly into thelintaction.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D92407627