Collapse lint action into test-all workflow#55427
Closed
huntie wants to merge 3 commits intofacebook:mainfrom
Closed
Collapse lint action into test-all workflow#55427huntie wants to merge 3 commits intofacebook:mainfrom
huntie wants to merge 3 commits intofacebook:mainfrom
Conversation
Summary: See blame — this script lints for a `"PATENTS"` string inside any Git changes, which should not occur any more. > D7119356 (8 years ago) > > [react-native][PR] Check PATENTS does not creep into files > > Summary: > Some files have crept into the repo with the old license header. These are usually from PRs that were opened prior to the re-licensing of the project. Changelog: [Internal] Differential Revision: D92417808
Summary: Changelog: [Internal] Differential Revision: D92417806
Summary: Following previous diffs, this now promotes the `lint` action to direct job steps. **Motivation** This has the advantage of making sub-steps in the GitHub UI visible, rather than running the 7 lint steps under a single banner. I feel this is justified in the case of `lint`, although increasing the size of `.github/workflowsl/test-all.yml` slightly, because: - Each step in this job is a distinct tool run with differing output, rather than one logical "action" — and this grouped output is therefore useful to the user. - Lint failures are reasonably frequent for users, emphasising the above. Changelog: [Internal] Differential Revision: D92417807
meta-cla
bot
added
the
CLA Signed
cortinico
approved these changes
Feb 5, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in 7e75234. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Following previous diffs, this now promotes the
lintaction to direct job steps.Motivation
This has the advantage of making sub-steps in the GitHub UI visible, rather than running the 7 lint steps under a single banner.
I feel this is justified in the case of
lint, although increasing the size of.github/workflowsl/test-all.ymlslightly, because:Changelog: [Internal]
Differential Revision: D92417807