Apply path filtering checks to test-all workflow#55429
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Apply path filtering checks to test-all workflow#55429huntie wants to merge 1 commit intofacebook:mainfrom
huntie wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Summary: Completes this stack of diffs focused around the organisation and efficiency of the `test-all` GitHub Actions workflow. **Changed** All root jobs (excluding `lint`), when running against a PR, now depend on the initial `check_code_changes` job. This matches any non-Markdown, non docs change — meaning trivial PRs such as changelog updates should now avoid unnecessarily running the expensive parts of this workflow. IMPORTANT: This is a significant change at the root of the workflow that contributes to our prebuilts/release infra — please review carefully. **The new `any_code_change` filter** Extremely defensive: - Matches `'!**/__docs__/**', '!**/*.md'` only. - Also **always** sets `any_code_change` to true if on `main`, a release branch, or on a workflow dispatch (`github.event_name != 'pull_request'`). Changelog: [Internal] Differential Revision: D92417918
huntie
force-pushed
the
export-D92417918
branch
from
eb6034e to
4d307e5
Compare
cortinico
approved these changes
Feb 6, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @huntie in b2b446e When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in b2b446e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Completes this stack of diffs focused around the organisation and efficiency of the
test-allGitHub Actions workflow.Changed
All root jobs (excluding
lint), when running against a PR, now depend on the initialcheck_code_changesjob. This matches any non-Markdown, non docs change — meaning trivial PRs such as changelog updates should now avoid unnecessarily running the expensive parts of this workflow.IMPORTANT: This is a significant change at the root of the workflow that contributes to our prebuilts/release infra — please review carefully.
The new
any_code_changefilterExtremely defensive:
'!**/__docs__/**', '!**/*.md'only.any_code_changeto true if onmain, a release branch, or on a workflow dispatch (github.event_name != 'pull_request').Changelog: [Internal]
Differential Revision: D92417918