Fix MissingSoLoaderLibrary: Add @SoLoaderLibrary to JSRuntimeFactory#55509
Open
mdvacca wants to merge 9 commits intofacebook:mainfrom
Open
Fix MissingSoLoaderLibrary: Add @SoLoaderLibrary to JSRuntimeFactory#55509mdvacca wants to merge 9 commits intofacebook:mainfrom
mdvacca wants to merge 9 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
mdvacca
force-pushed
the
export-D92023701
branch
4 times, most recently
from
bda901f to
2b3c620
Compare
mdvacca
force-pushed
the
export-D92023701
branch
from
2b3c620 to
10d64a2
Compare
Summary: The BaseVMFocusChangeListener inner class does not reference any members of its outer class BaseViewManager. Making it static improves memory efficiency by avoiding the implicit reference to the outer class instance. Also removed the unused type parameter <V extends View> and changed the method parameters from T to View since only View interface methods are used. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D92020879
…k#55502) Summary: This change adds missing Override annotations to three methods in LayoutShadowNode that override methods from the parent class: - setFlex(float) - setFlexGrow(float) - setFlexShrink(float) These methods call super.setFlex/setFlexGrow/setFlexShrink, indicating they override parent methods and should have Override annotations for code clarity and compiler checking. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92021000
…ebook#55503) Summary: Remove unused code that was triggering lint warnings: 1. Remove `walkUpUntilNativeKindIsParent` private method that was never invoked 2. Remove `parent` variable in `applyLayoutBase` that was never accessed Both were leftover from NativeKind removal. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92021031
…ok#55504) Summary: Replace `TextUtils.join(", ", features)` with the idiomatic Kotlin `features.joinToString(", ")`. This fixes the HasBetterKotlinAlternativeMethod lint warning and removes the now-unused TextUtils import. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92021387
…AttributeProps (facebook#55505) Summary: Replace `TextUtils.join(", ", features)` with Kotlin's idiomatic `features.joinToString(", ")` to fix the HasBetterKotlinAlternativeMethod lint warning. Also removed the now-unused `TextUtils` import while keeping the `TextUtils.TruncateAt` import that is still in use. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92021465
…#55506) Summary: Add the SoLoaderLibrary("jsijniprofiler") annotation to HermesSamplingProfiler to fix the MissingSoLoaderLibrary androidlint warning. This annotation helps track which native libraries are loaded by this class, improving build and startup optimization analysis. Also added the required dependency on soloader annotation library in the BUCK file. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92022030
) Summary: Replace TargetApi(29) with RequiresApi(29) in BlendModeHelper.kt to fix the UseRequiresApi lint warning. The RequiresApi annotation from AndroidX properly propagates the API level requirement to callers, while TargetApi only suppresses the lint warning locally without providing this safety. Also updated the import from android.annotation.TargetApi to androidx.annotation.RequiresApi. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92022472
…ostInspectorTarget (facebook#55508) Summary: This fixes the MissingSoLoaderLibrary lint warning in ReactHostInspectorTarget.kt by adding the SoLoaderLibrary("rninstance") annotation to the companion object that loads the native library via SoLoader.loadLibrary(). This annotation helps with static analysis and proper tracking of native library dependencies. Also adds the required soloader annotation dependency to the BUCK file. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92022954
…acebook#55509) Summary: Fixed MissingSoLoaderLibrary lint error in JSRuntimeFactory.kt. Added `SoLoaderLibrary("rninstance")` annotation to document that this class loads the "rninstance" native library via SoLoader. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92023701
mdvacca
force-pushed
the
export-D92023701
branch
from
10d64a2 to
6c5c3df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed MissingSoLoaderLibrary lint error in JSRuntimeFactory.kt.
Added
SoLoaderLibrary("rninstance")annotation to document that this class loadsthe "rninstance" native library via SoLoader.
changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D92023701