Fix unsafe rawPointer access in cloneMultiple#55613
Closed
bartlomiejbloniarz wants to merge 1 commit intomainfrom
Closed
Fix unsafe rawPointer access in cloneMultiple#55613bartlomiejbloniarz wants to merge 1 commit intomainfrom
bartlomiejbloniarz wants to merge 1 commit intomainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93596770. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
Summary: The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770
meta-codesync
bot
force-pushed
the
export-D93596770
branch
from
5ecac9d to
37d37ce
Compare
Job Summary for GradleTest All :: build_android
|
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Mar 3, 2026
Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770
bartlomiejbloniarz
force-pushed
the
export-D93596770
branch
from
37d37ce to
8e5de46
Compare
Collaborator
|
This pull request was successfully merged by @coado in 8e5de46 When will my fix make it into a release? | How to file a pick request? |
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
Summary: The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770
meta-codesync
bot
force-pushed
the
export-D93596770
branch
from
8e5de46 to
dfffda3
Compare
Job Summary for GradleTest All :: build_android
|
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Mar 3, 2026
Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770
bartlomiejbloniarz
force-pushed
the
export-D93596770
branch
from
dfffda3 to
f102dbe
Compare
Collaborator
|
This pull request was successfully merged by @coado in f102dbe When will my fix make it into a release? | How to file a pick request? |
Job Summary for GradleTest All :: build_android
|
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Mar 3, 2026
Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770
bartlomiejbloniarz
force-pushed
the
export-D93596770
branch
from
f102dbe to
6675f95
Compare
Collaborator
|
This pull request was successfully merged by @coado in 6675f95 When will my fix make it into a release? | How to file a pick request? |
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
Summary: The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770
meta-codesync
bot
force-pushed
the
export-D93596770
branch
from
6675f95 to
c66970c
Compare
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Mar 3, 2026
Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770
bartlomiejbloniarz
force-pushed
the
export-D93596770
branch
from
c66970c to
639c289
Compare
Collaborator
|
This pull request was successfully merged by @coado in 639c289 When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770
bartlomiejbloniarz
force-pushed
the
export-D93596770
branch
from
639c289 to
41f59c4
Compare
Collaborator
|
This pull request was successfully merged by @coado in 41f59c4 When will my fix make it into a release? | How to file a pick request? |
Collaborator
|
This pull request was successfully merged by @coado in 1d47693 When will my fix make it into a release? | How to file a pick request? |
alanleedev
pushed a commit
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Changelog: [General][Breaking] - fix unsafe rawPointer access in cloneMultiple. Reviewed By: zeyap, javache Differential Revision: D93596770 fbshipit-source-id: c4d99b51875968ebce50358c19502cba02c50685
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Changelog: [General][Breaking] - fix unsafe rawPointer access in cloneMultiple. Reviewed By: zeyap, javache Differential Revision: D93596770 fbshipit-source-id: c4d99b51875968ebce50358c19502cba02c50685
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated.
Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself.
This
cloneMultiplemethod isn't really adopted in the community, so the breaking change shouldn't be a big problem.Changelog:
[General][Breaking] - fix unsafe rawPointer access in cloneMultiple.
Differential Revision: D93596770