Generate Kotlin files with enums.py#55631
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
Summary: This PR extends enums.py to also write Kotlin files. To introduce this in the least breaking manner, we can gradually do one by one and at the end clean up the Java script. Migrate YogaDirection to Kotlin. Changelog: [Internal] X-link: facebook/yoga#1845 Reviewed By: cortinico Differential Revision: D93555645 Pulled By: NickGerleman
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93555645. |
meta-cla
Bot
added
the
CLA Signed
cortinico
approved these changes
Feb 19, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync Bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/react-native#55631 This PR extends enums.py to also write Kotlin files. To introduce this in the least breaking manner, we can gradually do one by one and at the end clean up the Java script. Migrate YogaDirection to Kotlin. Changelog: [Internal] Pull Request resolved: #1845 Test Plan: RN ```sh yarn android yarn test-android ``` Yoga ```sh ./gradlew :yoga:assembleDebug ``` Reviewed By: cortinico Differential Revision: D93555645 Pulled By: NickGerleman fbshipit-source-id: cdddc9850f05cf0782cc4fdb782f22776ab12d31
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 7e4c994 When will my fix make it into a release? | How to file a pick request? |
|
@NickGerleman merged this pull request in 7e4c994. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR extends enums.py to also write Kotlin files. To introduce this in the least breaking manner, we can gradually do one by one and at the end clean up the Java script.
Migrate YogaDirection to Kotlin.
Changelog: [Internal]
X-link: facebook/yoga#1845
Reviewed By: cortinico
Differential Revision: D93555645
Pulled By: NickGerleman