Register SelectableTextViewManager in all ReactPackages#55636
Closed
NickGerleman wants to merge 3 commits intofacebook:mainfrom
Closed
Register SelectableTextViewManager in all ReactPackages#55636NickGerleman wants to merge 3 commits intofacebook:mainfrom
NickGerleman wants to merge 3 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
NickGerleman
force-pushed
the
export-D93829403
branch
9 times, most recently
from
e904ab0 to
40b5eff
Compare
cortinico
approved these changes
Feb 26, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
NickGerleman
force-pushed
the
export-D93829403
branch
from
40b5eff to
c081842
Compare
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93829403. |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403
NickGerleman
force-pushed
the
export-D93829403
branch
from
c081842 to
ef80109
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403
Summary: Extract ParagraphComponentDescriptor logic into a template base class BaseParagraphComponentDescriptor<ShadowNodeT> so that other paragraph-like component descriptors can reuse the same TextLayoutManager wiring. Remove `final` from ParagraphShadowNode to allow subclassing. Move TextLayoutManagerKey from extern linkage in .cpp to constexpr in the new header. This is a pure refactor with no behavioral change. Changelog: [Internal] Differential Revision: D93829402
Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Differential Revision: D93829400
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403
NickGerleman
force-pushed
the
export-D93829403
branch
from
ef80109 to
9cd9177
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403
NickGerleman
force-pushed
the
export-D93829403
branch
from
9cd9177 to
8111dcb
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403
Summary: Pull Request resolved: facebook#55636 Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403
NickGerleman
force-pushed
the
export-D93829403
branch
from
8111dcb to
b289618
Compare
|
This pull request has been merged in da3b883. |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55636 Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation. Changelog: [Internal] Reviewed By: mdvacca, cortinico Differential Revision: D93829403 fbshipit-source-id: 36d51aa066344b5ebfb682413b05f366c6c3c603
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Register the new SelectableTextViewManager in every app's ReactPackage so it is available to the Fabric mounting layer. Since no JS code references RCTSelectableText yet, registering the ViewManager is a no-op at runtime. OptIn(UnstableReactNativeAPI::class) annotations are required because SelectableTextViewManager uses that annotation.
Changelog:
[Internal]
Differential Revision: D93829403