Skip to content

chore: fix typos in test descriptions and code comments#55651

Closed
szarbartosz wants to merge 2 commits intofacebook:mainfrom
szarbartosz:chore/fix-typos
Closed

chore: fix typos in test descriptions and code comments#55651
szarbartosz wants to merge 2 commits intofacebook:mainfrom
szarbartosz:chore/fix-typos

Conversation

@szarbartosz
Copy link
Copy Markdown
Contributor

Summary:

I was upgrading bare react native project to expo sdk 54 and stumbled upon

"TurboModule system assumes returnType == void iff the method is synchronous."

error from turbomodule/core/TurboModuleInteropUtils.kt

I thought that iff with double f was a typo and wanted to submit a pr with fix - I learned that it means if and only if - decided to scan the repo for any other typos anywany - submitting the ones that I've found.

Changelog:

[Internal]

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Feb 20, 2026

Hi @szarbartosz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link
Copy Markdown

Warning

Missing Test Plan

Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Feb 20, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Feb 20, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Feb 20, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Feb 20, 2026

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D93876470.

Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szarbartosz can you update the snapshots so the tests are passing?

@cortinico
Copy link
Copy Markdown
Contributor

/rebase

@meta-codesync meta-codesync Bot closed this in ac1aa75 Feb 23, 2026
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 23, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Feb 23, 2026

@cortinico merged this pull request in ac1aa75.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @szarbartosz in ac1aa75

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants