Skip to content

Increase frame capture quality, apply scaling after DPI normalization#55731

Open
huntie wants to merge 2 commits intofacebook:mainfrom
huntie:export-D94256691
Open

Increase frame capture quality, apply scaling after DPI normalization#55731
huntie wants to merge 2 commits intofacebook:mainfrom
huntie:export-D94256691

Conversation

@huntie
Copy link
Member

@huntie huntie commented Feb 24, 2026

Summary: Changelog: [Internal]

Updates Android screenshot capture for performance frame timings to improve image quality:

  • Fix scale factor calculation by first normalizing output size based on display density.
  • Increase (in most cases) output image size and encoding quality.

Impact

  • Output images are now net larger (depending on DPI), and have significantly more clarity.
  • Each captured frame now uses ~9x more space (vs a worst case device scaling starting point).

NOTE: These changes come with a memory tradeoff, and we may explore multi-frame sampling and a bounded buffer in future. Not a major bottleneck, even with this size increase (the bottleneck remains in expanding JS Sampling Profiler events).

Differential Revision: D94256691

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 24, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 24, 2026

@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94256691.

huntie added a commit to huntie/react-native that referenced this pull request Feb 24, 2026
…facebook#55731)

Summary:

Changelog: [Internal]

Differential Revision: D94256691
huntie added a commit to huntie/react-native that referenced this pull request Feb 24, 2026
…facebook#55731)

Summary:
Pull Request resolved: facebook#55731

Changelog: [Internal]

Differential Revision: D94256691
huntie added a commit to huntie/react-native that referenced this pull request Feb 25, 2026
…facebook#55731)

Summary:

Changelog: [Internal]

Differential Revision: D94256691
huntie added a commit to huntie/react-native that referenced this pull request Feb 25, 2026
…facebook#55731)

Summary:
Pull Request resolved: facebook#55731

Changelog: [Internal]

Differential Revision: D94256691
huntie added a commit to huntie/react-native that referenced this pull request Feb 25, 2026
…facebook#55731)

Summary:

Changelog: [Internal]

Differential Revision: D94256691
huntie added a commit to huntie/react-native that referenced this pull request Feb 25, 2026
…facebook#55731)

Summary:
Pull Request resolved: facebook#55731

Changelog: [Internal]

Differential Revision: D94256691
huntie added a commit to huntie/react-native that referenced this pull request Feb 25, 2026
…facebook#55731)

Summary:
Pull Request resolved: facebook#55731

Changelog: [Internal]

Differential Revision: D94256691
Summary:
Small refactor — locate public methods first, sort private methods in call order.

Changelog: [Internal]

Differential Revision: D94366535
…facebook#55731)

Summary:

Changelog: [Internal]

Differential Revision: D94256691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants