Default operator== definitions in react-native-github#55750
Closed
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Closed
Default operator== definitions in react-native-github#55750NickGerleman wants to merge 1 commit intofacebook:mainfrom
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Replace explicit `operator==` implementations with `= default` where the operator performs simple memberwise comparison of all data members. The compiler-generated defaulted operator is equivalent but less error-prone and easier to maintain as members are added or removed. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D94371201
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94371201. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 5993308 When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55750 Replace explicit `operator==` implementations with `= default` where the operator performs simple memberwise comparison of all data members. The compiler-generated defaulted operator is equivalent but less error-prone and easier to maintain as members are added or removed. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D94371201 fbshipit-source-id: 6510ba4a5c5eca4f8d5c2ca363e4d28df63f58b6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace explicit
operator==implementations with= defaultwhere theoperator performs simple memberwise comparison of all data members. The
compiler-generated defaulted operator is equivalent but less error-prone
and easier to maintain as members are added or removed.
Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D94371201