Fix race causing NPE in AccessibilityInfoModule event emission#55792
Closed
alanleedev wants to merge 1 commit intofacebook:mainfrom
Closed
Fix race causing NPE in AccessibilityInfoModule event emission#55792alanleedev wants to merge 1 commit intofacebook:mainfrom
alanleedev wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Fixing this reported crash: ``` android:java.lang.NullPointerException:com.facebook.react.modules.accessibilityinfo.AccessibilityInfoModule.updateAndSendTouchExplorationChangeEvent:unknown ``` Prevent `NullPointerException` crashes by removing a TOCTOU (Time-Of-Check to Time-Of-Use) race when emitting accessibility state change events. The React context can become invalid between check and use; using a safe call on `getReactApplicationContextIfActiveOrWarn` ensures events are only sent when the context is active. Changelog: [Internal] --- Differential Revision: D94558522
meta-cla
Bot
added
the
CLA Signed
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94558522. |
|
This pull request has been merged in 2f9711d. |
Collaborator
|
This pull request was successfully merged by @alanleedev in 2f9711d When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
…ook#55792) Summary: Pull Request resolved: facebook#55792 Fixing this reported crash: ``` android:java.lang.NullPointerException:com.facebook.react.modules.accessibilityinfo.AccessibilityInfoModule.updateAndSendTouchExplorationChangeEvent:unknown ``` Prevent `NullPointerException` crashes by removing a TOCTOU (Time-Of-Check to Time-Of-Use) race when emitting accessibility state change events. The React context can become invalid between check and use; using a safe call on `getReactApplicationContextIfActiveOrWarn` ensures events are only sent when the context is active. Changelog: [Internal] --- Reviewed By: mdvacca Differential Revision: D94558522 fbshipit-source-id: 46edbf745b482e7d212ae5f0ed7a9fa3db7c7ba2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixing this reported crash:
Prevent
NullPointerExceptioncrashes by removing a TOCTOU (Time-Of-Check to Time-Of-Use) race when emitting accessibility state change events.The React context can become invalid between check and use; using a safe call on
getReactApplicationContextIfActiveOrWarnensures events are only sent when the context is active.Changelog: [Internal]
Differential Revision: D94558522