Closed
Conversation
Summary: No need for a separate enum here when we can just use the std::variant itself. Changelog: [Internal] Changed layout of GradientDirection Reviewed By: sammy-SC Differential Revision: D94522238
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been merged in 7d4e5ef. |
Collaborator
|
This pull request was successfully merged by @javache in 7d4e5ef When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55800 No need for a separate enum here when we can just use the std::variant itself. Changelog: [Internal] Changed layout of GradientDirection Reviewed By: sammy-SC Differential Revision: D94522238 fbshipit-source-id: 7f02db573de4bf49e912795726adb302e91de969
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
No need for a separate enum here when we can just use the std::variant itself.
Changelog: [Internal] Changed layout of GradientDirection
Reviewed By: sammy-SC
Differential Revision: D94522238