Add back receiveTouches on RCTEventEmitter with default implementation#55850
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Add back receiveTouches on RCTEventEmitter with default implementation#55850javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: D91320248 removed `receiveTouches` from the `RCTEventEmitter` interface entirely. This was too big of a breaking change — ecosystem libraries that implement `RCTEventEmitter` or `RCTModernEventEmitter` and override `receiveTouches` would fail to compile. This brings back `receiveTouches` on `RCTEventEmitter` but with a default no-op implementation, so existing implementers that override it continue to compile, and new implementers don't need to provide one. Changelog: [Android][Changed] Re-added `receiveTouches` to `RCTEventEmitter` with a default no-op implementation to avoid breaking ecosystem libraries Differential Revision: D94903267
meta-cla
bot
added
the
CLA Signed
cortinico
approved these changes
Mar 2, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @javache in 67db89d When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
facebook#55850) Summary: Pull Request resolved: facebook#55850 D91320248 removed `receiveTouches` from the `RCTEventEmitter` interface entirely. This was too big of a breaking change — ecosystem libraries that implement `RCTEventEmitter` or `RCTModernEventEmitter` and override `receiveTouches` would fail to compile. This brings back `receiveTouches` on `RCTEventEmitter` but with a default no-op implementation, so existing implementers that override it continue to compile, and new implementers don't need to provide one. Changelog: [Android][Changed] Re-added `receiveTouches` to `RCTEventEmitter` with a default no-op implementation to avoid breaking ecosystem libraries Reviewed By: cortinico Differential Revision: D94903267 fbshipit-source-id: fd89da9714b02a72c6ff271375307f620f5d2e3d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D91320248 removed
receiveTouchesfrom theRCTEventEmitterinterface entirely.This was too big of a breaking change — ecosystem libraries that implement
RCTEventEmitterorRCTModernEventEmitterand overridereceiveToucheswouldfail to compile.
This brings back
receiveTouchesonRCTEventEmitterbut with a default no-opimplementation, so existing implementers that override it continue to compile, and
new implementers don't need to provide one.
Changelog: [Android][Changed] Re-added
receiveTouchestoRCTEventEmitterwith a default no-op implementation to avoid breaking ecosystem librariesDifferential Revision: D94903267