Add missing Fantom integration test coverage for TouchableHighlight#55928
Closed
ellemac123 wants to merge 1 commit intofacebook:mainfrom
Closed
Add missing Fantom integration test coverage for TouchableHighlight#55928ellemac123 wants to merge 1 commit intofacebook:mainfrom
ellemac123 wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@ellemac123 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95225416. |
ellemac123
force-pushed
the
export-D95225416
branch
from
2357518 to
ecd2cd2
Compare
ellemac123
pushed a commit
to ellemac123/react-native
that referenced
this pull request
Mar 5, 2026
…acebook#55928) Summary: Changelog: [Internal] Add tests for previously untested TouchableHighlight-specific features in the Fantom integration test suite: - **underlayColor**: Verify default underlay color ('black') and custom underlay color ('red') render correctly when pressed, using `testOnly_pressed={true}` to force the pressed visual state. - **activeOpacity (pressed state)**: Verify default activeOpacity (0.85) and custom activeOpacity (0.5) are applied to the child element's opacity when pressed. - **onShowUnderlay**: Verify the callback fires when the element is clicked, via `Fantom.dispatchNativeEvent`. - **displayName**: Verify `TouchableHighlight.displayName` is `'TouchableHighlight'`. These tests cover the underlay mechanism, which is the defining feature of TouchableHighlight that distinguishes it from TouchableOpacity. Reviewed By: NickGerleman Differential Revision: D95225416
ellemac123
force-pushed
the
export-D95225416
branch
from
ecd2cd2 to
1e901cc
Compare
ellemac123
pushed a commit
to ellemac123/react-native
that referenced
this pull request
Mar 5, 2026
…acebook#55928) Summary: Pull Request resolved: facebook#55928 Changelog: [Internal] Add tests for previously untested TouchableHighlight-specific features in the Fantom integration test suite: - **underlayColor**: Verify default underlay color ('black') and custom underlay color ('red') render correctly when pressed, using `testOnly_pressed={true}` to force the pressed visual state. - **activeOpacity (pressed state)**: Verify default activeOpacity (0.85) and custom activeOpacity (0.5) are applied to the child element's opacity when pressed. - **onShowUnderlay**: Verify the callback fires when the element is clicked, via `Fantom.dispatchNativeEvent`. - **displayName**: Verify `TouchableHighlight.displayName` is `'TouchableHighlight'`. These tests cover the underlay mechanism, which is the defining feature of TouchableHighlight that distinguishes it from TouchableOpacity. Reviewed By: NickGerleman Differential Revision: D95225416
…acebook#55928) Summary: Changelog: [Internal] Add tests for previously untested TouchableHighlight-specific features in the Fantom integration test suite: - **underlayColor**: Verify default underlay color ('black') and custom underlay color ('red') render correctly when pressed, using `testOnly_pressed={true}` to force the pressed visual state. - **activeOpacity (pressed state)**: Verify default activeOpacity (0.85) and custom activeOpacity (0.5) are applied to the child element's opacity when pressed. - **onShowUnderlay**: Verify the callback fires when the element is clicked, via `Fantom.dispatchNativeEvent`. - **displayName**: Verify `TouchableHighlight.displayName` is `'TouchableHighlight'`. These tests cover the underlay mechanism, which is the defining feature of TouchableHighlight that distinguishes it from TouchableOpacity. Reviewed By: NickGerleman Differential Revision: D95225416
ellemac123
force-pushed
the
export-D95225416
branch
from
1e901cc to
a53e660
Compare
|
This pull request has been merged in 6d4fcbf. |
Collaborator
|
This pull request was successfully merged by Laura Macaluso in 6d4fcbf When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
…acebook#55928) Summary: Pull Request resolved: facebook#55928 Changelog: [Internal] Add tests for previously untested TouchableHighlight-specific features in the Fantom integration test suite: - **underlayColor**: Verify default underlay color ('black') and custom underlay color ('red') render correctly when pressed, using `testOnly_pressed={true}` to force the pressed visual state. - **activeOpacity (pressed state)**: Verify default activeOpacity (0.85) and custom activeOpacity (0.5) are applied to the child element's opacity when pressed. - **onShowUnderlay**: Verify the callback fires when the element is clicked, via `Fantom.dispatchNativeEvent`. - **displayName**: Verify `TouchableHighlight.displayName` is `'TouchableHighlight'`. These tests cover the underlay mechanism, which is the defining feature of TouchableHighlight that distinguishes it from TouchableOpacity. Reviewed By: NickGerleman Differential Revision: D95225416 fbshipit-source-id: d1923c27d1ec9536d6b1e4ae41ba750212f27bc6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Add tests for previously untested TouchableHighlight-specific features
in the Fantom integration test suite:
underlayColor: Verify default underlay color ('black') and custom
underlay color ('red') render correctly when pressed, using
testOnly_pressed={true}to force the pressed visual state.activeOpacity (pressed state): Verify default activeOpacity (0.85)
and custom activeOpacity (0.5) are applied to the child element's
opacity when pressed.
onShowUnderlay: Verify the callback fires when the element is
clicked, via
Fantom.dispatchNativeEvent.displayName: Verify
TouchableHighlight.displayNameis'TouchableHighlight'.These tests cover the underlay mechanism, which is the defining feature
of TouchableHighlight that distinguishes it from TouchableOpacity.
Reviewed By: NickGerleman
Differential Revision: D95225416