Avoid spawning a new iOS simulator if one is already booted#55931
Closed
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Closed
Avoid spawning a new iOS simulator if one is already booted#55931fabriziocucci wants to merge 1 commit intofacebook:mainfrom
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [Internal] Previously, `testRNTesterIOS` would either unconditionally boot a new simulator (local build path) or check only for an exact "iPhone 16 Pro" match (CI artifacts path). This caused a new iOS simulator to always spawn even when one was already open. Extracted a `bootSimulatorIfNeeded` helper that checks for any booted simulator via `xcrun simctl list devices booted` before attempting to boot a new one. Reviewed By: cipolleschi Differential Revision: D95368633
meta-cla
bot
added
the
CLA Signed
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95368633. |
|
This pull request has been merged in 977ad71. |
Collaborator
|
This pull request was successfully merged by @fabriziocucci in 977ad71 When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
…#55931) Summary: Pull Request resolved: facebook#55931 Changelog: [Internal] Previously, `testRNTesterIOS` would either unconditionally boot a new simulator (local build path) or check only for an exact "iPhone 16 Pro" match (CI artifacts path). This caused a new iOS simulator to always spawn even when one was already open. Extracted a `bootSimulatorIfNeeded` helper that checks for any booted simulator via `xcrun simctl list devices booted` before attempting to boot a new one. Reviewed By: cipolleschi Differential Revision: D95368633 fbshipit-source-id: 858bd235486597b5c9dbb0b904fcd95707b92b13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Previously,
testRNTesterIOSwould either unconditionally boot a newsimulator (local build path) or check only for an exact "iPhone 16 Pro"
match (CI artifacts path). This caused a new iOS simulator to always
spawn even when one was already open.
Extracted a
bootSimulatorIfNeededhelper that checks for any bootedsimulator via
xcrun simctl list devices bootedbefore attempting toboot a new one.
Reviewed By: cipolleschi
Differential Revision: D95368633