Closed
Conversation
meta-cla
bot
added
the
CLA Signed
cortinico
approved these changes
Mar 6, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95311372. |
Summary: Add name fields to 5 Button examples in ButtonExample.js and create 5 corresponding E2E screenshot tests covering default-styling, color-red, two-buttons-flexbox, three-buttons-flexbox, and disabled variants. Skipped accessibility-only examples (no visual difference). Reviewed By: cortinico Differential Revision: D95311374
Summary: Add name fields and testID props to 5 cross-platform BoxShadow examples in BoxShadowExample.js and create 5 corresponding E2E screenshot tests. Tests exclude Android and mac platforms since BoxShadow is only registered in the iOS RNTesterList. Skipped Android-only elevation examples. Reviewed By: cortinico Differential Revision: D95311371
Summary: Add name fields and testID props to 10 static Transform examples in TransformExample.js and create 10 corresponding E2E screenshot tests. Skipped 3 animated examples (Perspective/Rotate/Animation, Animate Translate single prop, Transform origin) since continuous animations produce non-deterministic screenshots. Reviewed By: cortinico Differential Revision: D95311369
Summary: Add name fields to 4 Pressable examples in PressableExample.js and create 4 corresponding E2E interaction tests covering content-press, feedback-events, text-press, and hit-slop. Tests verify click interactions and text state changes rather than screenshots. Reviewed By: cortinico Differential Revision: D95311372
NickGerleman
force-pushed
the
export-D95311372
branch
from
ed4a82f to
f499559
Compare
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95311372. |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 6, 2026
Summary: Add name fields to 4 Pressable examples in PressableExample.js and create 4 corresponding E2E interaction tests covering content-press, feedback-events, text-press, and hit-slop. Tests verify click interactions and text state changes rather than screenshots. Reviewed By: cortinico Differential Revision: D95311372
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 6, 2026
Summary: Add name fields to 4 Pressable examples in PressableExample.js and create 4 corresponding E2E interaction tests covering content-press, feedback-events, text-press, and hit-slop. Tests verify click interactions and text state changes rather than screenshots. Reviewed By: cortinico Differential Revision: D95311372
|
This pull request has been merged in 9c1a1ad. |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55955 Add name fields to 4 Pressable examples in PressableExample.js and create 4 corresponding E2E interaction tests covering content-press, feedback-events, text-press, and hit-slop. Tests verify click interactions and text state changes rather than screenshots. Reviewed By: cortinico Differential Revision: D95311372 fbshipit-source-id: 629b6dc3c20b76b7107d15fa17e471c5d00503b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add name fields to 4 Pressable examples in PressableExample.js and create 4 corresponding E2E interaction tests covering content-press, feedback-events, text-press, and hit-slop. Tests verify click interactions and text state changes rather than screenshots.
Reviewed By: cortinico
Differential Revision: D95311372