Fix BoringLayout crash when isBoring() returns negative width#56007
Closed
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Closed
Fix BoringLayout crash when isBoring() returns negative width#56007NickGerleman wants to merge 1 commit intofacebook:mainfrom
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Fix a crash in `TextLayoutManager.isBoring()` where `BoringLayout.isBoring()` sometimes returns metrics with a negative width for certain strings, even on Android 15+. This causes issues downstream when the layout is created. The fix checks if the returned metrics have a negative width and falls back to `StaticLayout` instead, which (theoretically) handles these edge cases correctly. Changelog: [Android][Fixed] - Fix BoringLayout crash when isBoring() returns negative width Differential Revision: D95777908
meta-cla
Bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95777908. |
|
This pull request has been merged in d527f2d. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in d527f2d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix a crash in
TextLayoutManager.isBoring()whereBoringLayout.isBoring()sometimes returns metrics with a negative width for certain strings, even on Android 15+. This causes issues downstream when the layout is created.The fix checks if the returned metrics have a negative width and falls back to
StaticLayoutinstead, which (theoretically) handles these edge cases correctly.Changelog:
[Android][Fixed] - Fix BoringLayout crash when isBoring() returns negative width
Differential Revision: D95777908