Inline private type aliases in the API snapshot#56030
Closed
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Closed
Inline private type aliases in the API snapshot#56030j-piasecki wants to merge 1 commit intofacebook:mainfrom
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95920125. |
meta-cla
Bot
added
the
CLA Signed
Summary: Changelog: [Internal] Currently, the parser ignores all private sections, which causes private type aliases definitions not to be present in the snapshot. The refereces to those types can still appear in the public API, if they are resolvable to public types. This diff updates the parser to track private type definitions, and inline them when referenced from the public API. Differential Revision: D95920125
j-piasecki
force-pushed
the
export-D95920125
branch
from
7a4eaec to
f2bd0e7
Compare
cortinico
approved these changes
Mar 10, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @j-piasecki in 7f6790b When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 7f6790b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Currently, the parser ignores all private sections, which causes private type aliases definitions not to be present in the snapshot. The refereces to those types can still appear in the public API, if they are resolvable to public types.
This diff updates the parser to track private type definitions, and inline them when referenced from the public API.
Differential Revision: D95920125