Fix UnsafeDereference: Replace !! with checkNotNull in FilterHelper#56116
Closed
mdvacca wants to merge 5 commits intofacebook:mainfrom
Closed
Fix UnsafeDereference: Replace !! with checkNotNull in FilterHelper#56116mdvacca wants to merge 5 commits intofacebook:mainfrom
mdvacca wants to merge 5 commits intofacebook:mainfrom
Conversation
Summary:
Fixed MissingSoLoaderLibrary lint warning in InspectorFlags.kt.
Added SoLoaderLibrary("react_devsupportjni") annotation to the class which calls SoLoader.loadLibrary("react_devsupportjni") but was missing the annotation needed for build tools to sanity check JNI merging. Also added the soloader annotation Buck dependency.
changelog: [internal] internal
Differential Revision: D96784589
…erBinding
Summary:
Fixed MissingSoLoaderLibrary lint warning in UIConstantsProviderBinding.kt.
Added SoLoaderLibrary("uimanagerjni") annotation to the class which calls SoLoader.loadLibrary("uimanagerjni") but was missing the annotation needed for build tools to sanity check JNI merging. Also added the soloader annotation Buck dependency.
changelog: [internal] internal
Differential Revision: D96784679
…in WebSocketModule Summary: Fixed StringFormatTrivial lint warnings in WebSocketModule.kt. Replaced trivial String.format calls with Kotlin string templates for better performance. String.format creates a new Formatter instance on each call, while string templates are compiled to simple concatenation. changelog: [internal] internal Differential Revision: D96784739
Summary: Fixed UnsafeDereference lint warnings in FpsView.kt. Changed the `reactContext` parameter type from `ReactContext?` to `ReactContext` since the superclass FrameLayout requires a non-null Context anyway. This eliminates the need for !! operators. changelog: [internal] internal Differential Revision: D96784792
Summary: Fixed UnsafeDereference lint warning in FilterHelper.kt. Replaced `filters.getMap(i)!!` with `checkNotNull(filters.getMap(i))` in `isOnlyColorMatrixFilters` method to match the pattern used in other methods in the same class. changelog: [internal] internal Differential Revision: D96784843
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 320e3bd. |
Collaborator
|
This pull request was successfully merged by @mdvacca in 320e3bd When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed UnsafeDereference lint warning in FilterHelper.kt.
Replaced
filters.getMap(i)!!withcheckNotNull(filters.getMap(i))inisOnlyColorMatrixFiltersmethod to match the pattern used in other methods in the same class.changelog: [internal] internal
Differential Revision: D96784843