RN: Default reportErrorsAsExceptions w/o Global Property (#56197)#56197
Closed
yungsters wants to merge 1 commit intofacebook:mainfrom
Closed
RN: Default reportErrorsAsExceptions w/o Global Property (#56197)#56197yungsters wants to merge 1 commit intofacebook:mainfrom
reportErrorsAsExceptions w/o Global Property (#56197)#56197yungsters wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@yungsters has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97788692. |
…56197) Summary: Refactors `ExceptionsManager` so that `reportErrorsAsExceptions` defaults to `true` without setting the `console.reportErrorsAsExceptions` global property. This reduces the amount of non-idiomatic code that needs to be maintained, and it also makes it clearer that the default of `reportErrorsAsExceptions` is `true`. (It already is, but now it's more obvious by reading the conditional.) This is *technically* a change in behavior of a public interface, but it's very subtle and — for most if not all codebases — should not result in any change in behavior. Changelog: [General][Changed] - Setting `reportErrorsAsExceptions` to anything other than `false` no longer does anything. (Previously, setting it to a falsey value would be similar to setting it to `false`.) Differential Revision: D97788692
meta-codesync
Bot
changed the title
reportErrorsAsExceptions w/o Global PropertyreportErrorsAsExceptions w/o Global Property (#56197)
yungsters
force-pushed
the
export-D97788692
branch
from
d73e70a to
dd4dbd7
Compare
Collaborator
|
This pull request was successfully merged by @yungsters in f0748a6 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in f0748a6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors
ExceptionsManagerso thatreportErrorsAsExceptionsdefaults totruewithout setting theconsole.reportErrorsAsExceptionsglobal property.This reduces the amount of non-idiomatic code that needs to be maintained, and it also makes it clearer that the default of
reportErrorsAsExceptionsistrue. (It already is, but now it's more obvious by reading the conditional.)This is technically a change in behavior of a public interface, but it's very subtle and — for most if not all codebases — should not result in any change in behavior.
Changelog:
[General][Changed] - Setting
reportErrorsAsExceptionsto anything other thanfalseno longer does anything. (Previously, setting it to a falsey value would be similar to setting it tofalse.)Differential Revision: D97788692