Schedule React revision merge to happen before dispatching events (#56449)#56449
Closed
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Closed
Schedule React revision merge to happen before dispatching events (#56449)#56449j-piasecki wants to merge 1 commit intofacebook:mainfrom
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100966623. |
facebook-github-tools
bot
added
p: Software Mansion
meta-codesync
bot
changed the title
j-piasecki
force-pushed
the
export-D100966623
branch
from
e0a6801 to
d39d34c
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Apr 15, 2026
…cebook#56449) Summary: Changelog: [ANDROID][FIXED] Schedule React revision merge to happen on `DISPATCH_UI` choreographer queue, before dispatching events Before the introduction of branching, it was possible to handle synchronous events on the same frame they were dispatched. Branching broke that in two ways: 1. Merge was always scheduled on the end of the event loop (addressed by the previous diff) 2. Merge was scheduled using `runOnUIThread`, which turned out to be after the `DISPATCH_UI` choreographer phase, thus after the dispatch of events. Differential Revision: D100966623
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Apr 15, 2026
…cebook#56449) Summary: Changelog: [ANDROID][FIXED] Schedule React revision merge to happen on `DISPATCH_UI` choreographer queue, before dispatching events Before the introduction of branching, it was possible to handle synchronous events on the same frame they were dispatched. Introduction of branching broke that because merge was scheduled using `runOnUIThread`, which turned out to be after the `DISPATCH_UI` choreographer phase, thus after the dispatch of events. Differential Revision: D100966623
j-piasecki
force-pushed
the
export-D100966623
branch
from
d39d34c to
f4f1a7c
Compare
…cebook#56449) Summary: Changelog: [ANDROID][FIXED] Schedule React revision merge to happen on `DISPATCH_UI` choreographer queue, before dispatching events Before the introduction of branching, it was possible to handle synchronous events on the same frame they were dispatched. Introduction of branching broke that because merge was scheduled using `runOnUIThread`, which turned out to be after the `DISPATCH_UI` choreographer phase, thus after the dispatch of events. Reviewed By: rubennorte Differential Revision: D100966623
j-piasecki
force-pushed
the
export-D100966623
branch
from
f4f1a7c to
1755ea5
Compare
Collaborator
|
This pull request was successfully merged by @j-piasecki in b63efbf When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in b63efbf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [ANDROID][FIXED] Schedule React revision merge to happen on
DISPATCH_UIchoreographer queue, before dispatching eventsBefore the introduction of branching, it was possible to handle synchronous events on the same frame they were dispatched. Introduction of branching broke that because merge was scheduled using
runOnUIThread, which turned out to be after theDISPATCH_UIchoreographer phase, thus after the dispatch of events.Reviewed By: rubennorte
Differential Revision: D100966623