Deprecate ViewUtil.getUIManagerType and inline UIManagerType.Fabric (#56451)#56451
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Deprecate ViewUtil.getUIManagerType and inline UIManagerType.Fabric (#56451)#56451javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
…acebook#56451) Summary: With Fabric as the only supported renderer, `ViewUtil.getUIManagerType()` always returns `UIManagerType.FABRIC`. This diff inlines that constant throughout and removes all Paper-only code paths: - `ReactRootView.setIsFabric()` → no-op, `getUIManagerType()` → returns FABRIC - `ReactInstanceManager.attachRootViewToInstance` → Fabric-only (removes `addRootView`/`runApplication` path) - `ReactInstanceManager.detachRootViewFromInstance` → removes `AppRegistry.unmountApplicationComponentAtRootTag` path - `NativeAnimatedModule` → removes Fabric/non-Fabric animation counting, `willDispatchViewUpdates` is no-op - `PropsAnimatedNode.restoreDefaultValues()` → no-op (was only relevant for Paper ShadowNode sync) - `BackgroundStyleApplicator` → removes Fabric guards on outline/boxShadow/filter/blendMode setters - `BaseViewManager` → removes Fabric guards on filter/mixBlendMode - `TransformHelper` → removes `allowPercentageResolution` parameter (always true) - `TouchTargetHelper` → removes Fabric guard on overflow inset check - `ComponentsReactNativeSupportProcessor` → removes legacy Litho view creation path - `ReactHorizontalScrollContainerLegacyView` → deleted, `ReactHorizontalScrollContainerViewManager` simplified - `ReactTextView` → removes Paper-specific text update logic - `ViewUtil.getUIManagerType()` → deprecated, hardcoded to return FABRIC Changelog: [Internal] Reviewed By: christophpurrer, NickGerleman Differential Revision: D91222827
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D91222827
branch
from
9114ddc to
6667fc9
Compare
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
|
This pull request has been merged in bedf33f. |
Collaborator
|
This pull request was successfully merged by @javache in bedf33f When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With Fabric as the only supported renderer,
ViewUtil.getUIManagerType()always returnsUIManagerType.FABRIC. This diff inlines that constant throughout and removes all Paper-only code paths:ReactRootView.setIsFabric()→ no-op,getUIManagerType()→ returns FABRICReactInstanceManager.attachRootViewToInstance→ Fabric-only (removesaddRootView/runApplicationpath)ReactInstanceManager.detachRootViewFromInstance→ removesAppRegistry.unmountApplicationComponentAtRootTagpathNativeAnimatedModule→ removes Fabric/non-Fabric animation counting,willDispatchViewUpdatesis no-opPropsAnimatedNode.restoreDefaultValues()→ no-op (was only relevant for Paper ShadowNode sync)BackgroundStyleApplicator→ removes Fabric guards on outline/boxShadow/filter/blendMode settersBaseViewManager→ removes Fabric guards on filter/mixBlendModeTransformHelper→ removesallowPercentageResolutionparameter (always true)TouchTargetHelper→ removes Fabric guard on overflow inset checkComponentsReactNativeSupportProcessor→ removes legacy Litho view creation pathReactHorizontalScrollContainerLegacyView→ deleted,ReactHorizontalScrollContainerViewManagersimplifiedReactTextView→ removes Paper-specific text update logicViewUtil.getUIManagerType()→ deprecated, hardcoded to return FABRICChangelog: [Internal]
Reviewed By: christophpurrer, NickGerleman
Differential Revision: D91222827