Allow waiting for user land Animated animations before firing transition complete callback (#56459)#56459
Closed
zeyap wants to merge 8 commits intofacebook:mainfrom
Closed
Allow waiting for user land Animated animations before firing transition complete callback (#56459)#56459zeyap wants to merge 8 commits intofacebook:mainfrom
zeyap wants to merge 8 commits intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Apr 15, 2026
…ion complete callback (facebook#56459) Summary: Pull Request resolved: facebook#56459 ## Changelog: [Internal] [Added] - Allow waiting for user land Animated animations before firing transition complete callback Instead of calling `onCompleteCallback` synchronously at the end of `startViewTransition`, defer it until all animations have finished. Since transition animation can be kicked off in user land from view transition event handlers, we need extra APIs to signal to native side when animation starts and finishes. This ensures the transition lifecycle properly waits for native animated transitions to complete. - Add `waitForTransitionAnimation` / `transitionAnimationFinished` to the delegate interface and expose via `NativeViewTransition` TurboModule - JS calls `waitForTransitionAnimation(animationId)` before starting each animation and `transitionAnimationFinished(animationId)` in the completion callback - `ViewTransitionModule` tracks pending animation IDs in a `std::set` and fires `onCompleteCallback_` only when all animations are done - only track and wait for animations started during transition-ready callback - if no animation requests to be waited for, resolve complete promise immediately when transition-ready callback finishes Reviewed By: sammy-SC Differential Revision: D99366980
meta-codesync
Bot
changed the title
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Apr 15, 2026
…ion complete callback (facebook#56459) Summary: Pull Request resolved: facebook#56459 ## Changelog: [Internal] [Added] - Allow waiting for user land Animated animations before firing transition complete callback Instead of calling `onCompleteCallback` synchronously at the end of `startViewTransition`, defer it until all animations have finished. Since transition animation can be kicked off in user land from view transition event handlers, we need extra APIs to signal to native side when animation starts and finishes. This ensures the transition lifecycle properly waits for native animated transitions to complete. - Add `waitForTransitionAnimation` / `transitionAnimationFinished` to the delegate interface and expose via `NativeViewTransition` TurboModule - JS calls `waitForTransitionAnimation(animationId)` before starting each animation and `transitionAnimationFinished(animationId)` in the completion callback - `ViewTransitionModule` tracks pending animation IDs in a `std::set` and fires `onCompleteCallback_` only when all animations are done - only track and wait for animations started during transition-ready callback - if no animation requests to be waited for, resolve complete promise immediately when transition-ready callback finishes Reviewed By: sammy-SC Differential Revision: D99366980
added 7 commits
April 15, 2026 11:50
Summary:
Implement `createViewTransitionInstance`, which is invoked by the React reconciler to create pseudo-element shadow nodes that visually represent the old state of elements participating in a view transition.
Key changes:
- Add `createViewTransitionInstance` JSI binding in `UIManagerBinding`, accepting a transition name and pseudo-element tag
- Add virtual `createViewTransitionInstance` method to `UIManagerViewTransitionDelegate`
- Implement the method in `ViewTransitionModule`: creates an absolutely-positioned, non-interactive `View` shadow node matching the old element's layout metrics (position, size)
- Manage two pseudo-element node maps: `oldPseudoElementNodes_` for the current transition and `oldPseudoElementNodesForNextTransition_` for entering nodes that may exit in a future transition
- Update `getOldViewTransitionInstance` to return the pseudo-element's tag (instead of the original element's tag) when a pseudo-element exists
- Add `applySnapshotsOnPseudoElementShadowNodes` stub for future platform-level bitmap snapshot integration
`createViewTransitionInstance` is typically called after `applyViewTransitionName` in the React reconciler. See the diagram below for the full flow.
{F1987481080}
Differential Revision: D98981886
Summary: Append view transition pseudo-element shadow nodes to the root's children at commit time (`shadowTreeWillCommit`), so they are committed into the shadow tree and rendered by the platform. Key changes: - Add `getPseudoElementNodes(surfaceId)` virtual method to `UIManagerViewTransitionDelegate`, returning pseudo-element shadow nodes filtered by surface ID - Implement the method in `ViewTransitionModule`, iterating over `oldPseudoElementNodes_` and collecting nodes matching the given surface - In `shadowTreeWillCommit`, when view transitions are enabled, query the delegate for pseudo-element nodes and insert them at the end of `rootChildren` before committing This ensures pseudo-element nodes (created by `createViewTransitionInstance`) are included in the committed shadow tree and ultimately mounted as platform views that display old-element snapshots during transitions. Differential Revision: D98982122
Summary: Add `findPseudoElementShadowNodeByTag` to look up pseudo-element shadow nodes by tag from JS, and update the animation helper to connect animated nodes to pseudo-element shadow nodes for old-element animations. Key changes: - Add `findPseudoElementShadowNodeByTag(tag)` virtual method to `UIManagerViewTransitionDelegate` and implement in `ViewTransitionModule` (linear scan over `oldPseudoElementNodes_`) - Expose the method via `NativeViewTransition` TurboModule so JS can resolve a pseudo-element's shadow node by its native tag - Add `findPseudoElementShadowNodeByTag` to `NativeViewTransition.js` spec - Update `ViewTransitionAnimationHelper.js`: - `animateInternal` accepts a new `pseudo` parameter (`'old'` | `'new'`) - When `pseudo === 'old'`, use `findPseudoElementShadowNodeByTag` instead of `findShadowNodeByTag_DEPRECATED` to connect animated nodes to the correct shadow node family - Pass `'new'` for enter animations and propagate `_pseudo` from pseudo-element objects for exit animations Differential Revision: D98982251
Summary: Wire view transition bitmap snapshot capture and display through the C++ delegate chain so platforms can implement snapshotting old-element views. **ViewTransitionModule.cpp**: Call `uiManagerDidCaptureViewSnapshot(tag, surfaceId)` in `applyViewTransitionName` to capture a bitmap of the old view while it is still mounted, and `uiManagerDidSetViewSnapshot(sourceTag, targetTag, surfaceId)` in `applySnapshotsOnPseudoElementShadowNodes` to map captured bitmaps onto pseudo-element views. **UIManagerDelegate / SchedulerDelegate**: Add pure virtual `captureViewSnapshot` and `setViewSnapshot` methods. **Scheduler**: Forward `UIManagerDelegate` calls to `SchedulerDelegate`. **Platform stubs**: Empty implementations for iOS (`RCTScheduler.mm`), CxxPlatform (`SchedulerDelegateImpl`), and Android JNI (`FabricUIManagerBinding`) — Android implementation follows in D99173446. Differential Revision: D98354659
Summary: Implement the Android side of view transition bitmap snapshots. **`ViewTransitionSnapshotManager`** (new Kotlin class): Manages the full snapshot lifecycle as a `UIManagerListener`. Captures bitmaps on the UI thread, maps them from source to target pseudo-element tags, re-applies after mount cycles (since views may be recreated), and self-cleans when views are deleted. **JNI bridge:** `FabricUIManagerBinding` → `FabricMountingManager` → `FabricUIManager` JNI delegates to the snapshot manager. **`SurfaceMountingManager.applyViewSnapshot`:** sets bitmap as view background using the KTX `Bitmap.toDrawable` extension. Differential Revision: D99173446
Summary: When a new view transition starts while another is still active, queue it instead of running immediately. The queued transition runs after the current one finishes via `startViewTransitionEnd`. - Add `suspendOnActiveViewTransition()` to `UIManagerViewTransitionDelegate`, exposed as a method on `nativeFabricUIManager` so the reconciler can signal suspension - `ViewTransitionModule` queues pending transitions in a `std::queue<PendingTransition>` when `suspendNextTransition_` is set - `startViewTransitionEnd` drains the queue sequentially, each transition triggering the next on completion Differential Revision: D99366975
Summary: Add `startViewTransitionReadyFinished()` to the view transition delegate so the reconciler can notify the native side when the ready callback's async work (e.g. spawned work from the `ready` promise `.then`) has completed. This was previously not capturable from the C++ side since `onReadyCallback` resolves the JS promise synchronously but the reconciler's follow-up work runs as a microtask. - Add `startViewTransitionReadyFinished` to `UIManagerViewTransitionDelegate` and `ViewTransitionModule` - Expose as a method on `nativeFabricUIManager` via `UIManagerBinding` - Track `transitionReadyFinished_` state, reset to `false` before `onReadyCallback` and set to `true` when the reconciler calls back Differential Revision: D99443648
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Apr 15, 2026
…ion complete callback (facebook#56459) Summary: Pull Request resolved: facebook#56459 ## Changelog: [Internal] [Added] - Allow waiting for user land Animated animations before firing transition complete callback Instead of calling `onCompleteCallback` synchronously at the end of `startViewTransition`, defer it until all animations have finished. Since transition animation can be kicked off in user land from view transition event handlers, we need extra APIs to signal to native side when animation starts and finishes. This ensures the transition lifecycle properly waits for native animated transitions to complete. - Add `waitForTransitionAnimation` / `transitionAnimationFinished` to the delegate interface and expose via `NativeViewTransition` TurboModule - JS calls `waitForTransitionAnimation(animationId)` before starting each animation and `transitionAnimationFinished(animationId)` in the completion callback - `ViewTransitionModule` tracks pending animation IDs in a `std::set` and fires `onCompleteCallback_` only when all animations are done - only track and wait for animations started during transition-ready callback - if no animation requests to be waited for, resolve complete promise immediately when transition-ready callback finishes Reviewed By: sammy-SC Differential Revision: D99366980
…ion complete callback (facebook#56459) Summary: Pull Request resolved: facebook#56459 ## Changelog: [Internal] [Added] - Allow waiting for user land Animated animations before firing transition complete callback Instead of calling `onCompleteCallback` synchronously at the end of `startViewTransition`, defer it until all animations have finished. Since transition animation can be kicked off in user land from view transition event handlers, we need extra APIs to signal to native side when animation starts and finishes. This ensures the transition lifecycle properly waits for native animated transitions to complete. - Add `waitForTransitionAnimation` / `transitionAnimationFinished` to the delegate interface and expose via `NativeViewTransition` TurboModule - JS calls `waitForTransitionAnimation(animationId)` before starting each animation and `transitionAnimationFinished(animationId)` in the completion callback - `ViewTransitionModule` tracks pending animation IDs in a `std::set` and fires `onCompleteCallback_` only when all animations are done - only track and wait for animations started during transition-ready callback - if no animation requests to be waited for, resolve complete promise immediately when transition-ready callback finishes Reviewed By: sammy-SC Differential Revision: D99366980
|
This pull request has been merged in a4f78b3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Added] - Allow waiting for user land Animated animations before firing transition complete callback
Instead of calling
onCompleteCallbacksynchronously at the end ofstartViewTransition, defer it until all animations have finished. Since transition animation can be kicked off in user land from view transition event handlers, we need extra APIs to signal to native side when animation starts and finishes. This ensures the transition lifecycle properly waits for native animated transitions to complete.waitForTransitionAnimation/transitionAnimationFinishedto the delegate interface and expose viaNativeViewTransitionTurboModulewaitForTransitionAnimation(animationId)before starting each animation andtransitionAnimationFinished(animationId)in the completion callbackViewTransitionModuletracks pending animation IDs in astd::setand firesonCompleteCallback_only when all animations are doneReviewed By: sammy-SC
Differential Revision: D99366980