Fix unused parameter warnings in NativeFantomTestSpecificMethods.cpp (#56492)#56492
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Fix unused parameter warnings in NativeFantomTestSpecificMethods.cpp (#56492)#56492christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101108571. |
cortinico
approved these changes
Apr 21, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56492) Summary: Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
29070bf to
59fdd8a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56492) Summary: Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
59fdd8a to
cd67aa9
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56492) Summary: Pull Request resolved: facebook#56492 Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
cd67aa9 to
6dd0c10
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
…acebook#56492) Summary: Pull Request resolved: facebook#56492 Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
6dd0c10 to
914527f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
…acebook#56492) Summary: Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
914527f to
21f4b5c
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
…acebook#56492) Summary: Pull Request resolved: facebook#56492 Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
21f4b5c to
24d967f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
…acebook#56492) Summary: Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Changelog: [Internal[ Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
24d967f to
4d159b9
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
…acebook#56492) Summary: Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
4d159b9 to
a54d8ca
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
…acebook#56492) Summary: Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
a54d8ca to
75739b7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
…acebook#56492) Summary: Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
75739b7 to
273a513
Compare
…acebook#56492) Summary: Pull Request resolved: facebook#56492 Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D101108571
christophpurrer
force-pushed
the
export-D101108571
branch
from
273a513 to
3d981f3
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 089276a When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 089276a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed clang-diagnostic-unused-parameter warnings by commenting out unused parameters in the takeFunctionAndNoop method. This method appears to be a no-op function that takes a callback but doesn't use it, likely for testing purposes.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D101108571