Add Buck CLI override for Kotlin feature flag defaults#56558
Closed
motiz88 wants to merge 2 commits intofacebook:mainfrom
Closed
Add Buck CLI override for Kotlin feature flag defaults#56558motiz88 wants to merge 2 commits intofacebook:mainfrom
motiz88 wants to merge 2 commits intofacebook:mainfrom
Conversation
Summary: Replaces the regex-based core of the Buck RN C++ feature flag override mechanism (D101484355) with a `tree-sitter` parser for sustainability. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D101629456
Summary: The C++ feature flag default override mechanism (D101484355) only affects `ReactNativeFeatureFlagsDefaults.h`. When flags are read from the Kotlin side, `ReactNativeFeatureFlagsDefaults.kt` is used instead — its defaults are duplicated rather than read via JNI (see comment in the file: "more expensive than just duplicating the defaults here"). Here, we apply the same `--config react_native.feature_flag_defaults` override to the Kotlin file at build time, using the same genrule pattern. A regex-based Python script rewrites `override fun <name>(): <Type> = <value>` lines. Changelog: [Internal] Differential Revision: D101974653
meta-cla
Bot
added
the
CLA Signed
|
@motiz88 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101974653. |
|
This pull request has been merged in e67dba1. |
Collaborator
|
This pull request was successfully merged by @motiz88 in e67dba1 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The C++ feature flag default override mechanism (D101484355) only affects
ReactNativeFeatureFlagsDefaults.h. When flags are read from the Kotlin side,ReactNativeFeatureFlagsDefaults.ktis used instead — its defaults are duplicated rather than read via JNI (see comment in the file: "more expensive than just duplicating the defaults here").Here, we apply the same
--config react_native.feature_flag_defaultsoverride to the Kotlin file at build time, using the same genrule pattern. A regex-based Python script rewritesoverride fun <name>(): <Type> = <value>lines.Changelog: [Internal]
Differential Revision: D101974653