Port TextInput-test.js to Fantom and remove the legacy Jest test (#56559) by rubennorte · Pull Request #56559 · facebook/react-native

rubennorte · 2026-04-22T12:12:17Z

Summary:

Migrates the remaining meaningful coverage from TextInput-test.js (Jest with snapshots) over to TextInput-itest.js (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one.

Changes in TextInput-itest.js:

Add a focus() test verifying that focusing a TextInput unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused").
Add a top-level has the correct displayName test.
Add a new set of props describes that assert the props from the original Jest snapshot tests reach the mounting layer via getRenderedOutput({props: [...]}).toJSX():
- id and nativeID: id → nativeID mapping, nativeID pass-through, and id precedence over nativeID.
- testID: pass-through.
- aria-label and accessibilityLabel: aria-label → accessibilityLabel mapping and accessibilityLabel pass-through.
- aria-* and accessibilityState: aria-busy/checked/disabled/expanded/selected mapped into accessibilityState.
- accessibilityRole: pass-through.
- style: backgroundColor propagated as a native color value.

Tests intentionally NOT ported:

Inherited HostInstance method presence checks (focus, blur, setNativeProps, measure, measureInWindow, measureLayout): they are guaranteed by Flow typing on ReactNativeElement, exercised in ReactNativeElement-itest.js, and Flow's method-unbinding rule prevents the simple toBeInstanceOf(Function) check without $FlowFixMe (which is forbidden by project rules).
focus() should not do anything if the TextInput is not editable: TextInputState.focusTextInput reads textField.currentProps?.editable, but in the new architecture currentProps is not exposed on the public ReactNativeElement instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching currentProps. Documenting this as expected behavior in Fantom would mask a real bug.
should give precedence to textContentType when set: textContentType is iOS-only and Fantom defaults to Android (AndroidTextInput).

Files removed:

Libraries/Components/TextInput/__tests__/TextInput-test.js
Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D101977225

meta-codesync · 2026-04-22T12:12:25Z

@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101977225.

…ebook#56559) Summary: Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one. Changes in `TextInput-itest.js`: - Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused"). - Add a top-level `has the correct displayName` test. - Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`: - `id and nativeID`: `id` → `nativeID` mapping, `nativeID` pass-through, and `id` precedence over `nativeID`. - `testID`: pass-through. - `aria-label and accessibilityLabel`: `aria-label` → `accessibilityLabel` mapping and `accessibilityLabel` pass-through. - `aria-* and accessibilityState`: `aria-busy/checked/disabled/expanded/selected` mapped into `accessibilityState`. - `accessibilityRole`: pass-through. - `style`: `backgroundColor` propagated as a native color value. Tests intentionally NOT ported: - Inherited `HostInstance` method presence checks (`focus`, `blur`, `setNativeProps`, `measure`, `measureInWindow`, `measureLayout`): they are guaranteed by Flow typing on `ReactNativeElement`, exercised in `ReactNativeElement-itest.js`, and Flow's `method-unbinding` rule prevents the simple `toBeInstanceOf(Function)` check without `$FlowFixMe` (which is forbidden by project rules). - `focus() should not do anything if the TextInput is not editable`: `TextInputState.focusTextInput` reads `textField.currentProps?.editable`, but in the new architecture `currentProps` is not exposed on the public `ReactNativeElement` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching `currentProps`. Documenting this as expected behavior in Fantom would mask a real bug. - `should give precedence to textContentType when set`: `textContentType` is iOS-only and Fantom defaults to Android (`AndroidTextInput`). Files removed: - `Libraries/Components/TextInput/__tests__/TextInput-test.js` - `Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap` Changelog: [Internal] Differential Revision: D101977225

…ebook#56559) Summary: Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one. Changes in `TextInput-itest.js`: - Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused"). - Add a top-level `has the correct displayName` test. - Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`: - `id and nativeID`: `id` → `nativeID` mapping, `nativeID` pass-through, and `id` precedence over `nativeID`. - `testID`: pass-through. - `aria-label and accessibilityLabel`: `aria-label` → `accessibilityLabel` mapping and `accessibilityLabel` pass-through. - `aria-* and accessibilityState`: `aria-busy/checked/disabled/expanded/selected` mapped into `accessibilityState`. - `accessibilityRole`: pass-through. - `style`: `backgroundColor` propagated as a native color value. Tests intentionally NOT ported: - Inherited `HostInstance` method presence checks (`focus`, `blur`, `setNativeProps`, `measure`, `measureInWindow`, `measureLayout`): they are guaranteed by Flow typing on `ReactNativeElement`, exercised in `ReactNativeElement-itest.js`, and Flow's `method-unbinding` rule prevents the simple `toBeInstanceOf(Function)` check without `$FlowFixMe` (which is forbidden by project rules). - `focus() should not do anything if the TextInput is not editable`: `TextInputState.focusTextInput` reads `textField.currentProps?.editable`, but in the new architecture `currentProps` is not exposed on the public `ReactNativeElement` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching `currentProps`. Documenting this as expected behavior in Fantom would mask a real bug. - `should give precedence to textContentType when set`: `textContentType` is iOS-only and Fantom defaults to Android (`AndroidTextInput`). Files removed: - `Libraries/Components/TextInput/__tests__/TextInput-test.js` - `Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap` Changelog: [Internal] Reviewed By: javache Differential Revision: D101977225

…ebook#56559) Summary: Pull Request resolved: facebook#56559 Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one. Changes in `TextInput-itest.js`: - Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused"). - Add a top-level `has the correct displayName` test. - Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`: - `id and nativeID`: `id` → `nativeID` mapping, `nativeID` pass-through, and `id` precedence over `nativeID`. - `testID`: pass-through. - `aria-label and accessibilityLabel`: `aria-label` → `accessibilityLabel` mapping and `accessibilityLabel` pass-through. - `aria-* and accessibilityState`: `aria-busy/checked/disabled/expanded/selected` mapped into `accessibilityState`. - `accessibilityRole`: pass-through. - `style`: `backgroundColor` propagated as a native color value. Tests intentionally NOT ported: - Inherited `HostInstance` method presence checks (`focus`, `blur`, `setNativeProps`, `measure`, `measureInWindow`, `measureLayout`): they are guaranteed by Flow typing on `ReactNativeElement`, exercised in `ReactNativeElement-itest.js`, and Flow's `method-unbinding` rule prevents the simple `toBeInstanceOf(Function)` check without `$FlowFixMe` (which is forbidden by project rules). - `focus() should not do anything if the TextInput is not editable`: `TextInputState.focusTextInput` reads `textField.currentProps?.editable`, but in the new architecture `currentProps` is not exposed on the public `ReactNativeElement` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching `currentProps`. Documenting this as expected behavior in Fantom would mask a real bug. - `should give precedence to textContentType when set`: `textContentType` is iOS-only and Fantom defaults to Android (`AndroidTextInput`). Files removed: - `Libraries/Components/TextInput/__tests__/TextInput-test.js` - `Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap` Changelog: [Internal] Reviewed By: javache Differential Revision: D101977225

…ebook#56559) Summary: Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one. Changes in `TextInput-itest.js`: - Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused"). - Add a top-level `has the correct displayName` test. - Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`: - `id and nativeID`: `id` → `nativeID` mapping, `nativeID` pass-through, and `id` precedence over `nativeID`. - `testID`: pass-through. - `aria-label and accessibilityLabel`: `aria-label` → `accessibilityLabel` mapping and `accessibilityLabel` pass-through. - `aria-* and accessibilityState`: `aria-busy/checked/disabled/expanded/selected` mapped into `accessibilityState`. - `accessibilityRole`: pass-through. - `style`: `backgroundColor` propagated as a native color value. Tests intentionally NOT ported: - Inherited `HostInstance` method presence checks (`focus`, `blur`, `setNativeProps`, `measure`, `measureInWindow`, `measureLayout`): they are guaranteed by Flow typing on `ReactNativeElement`, exercised in `ReactNativeElement-itest.js`, and Flow's `method-unbinding` rule prevents the simple `toBeInstanceOf(Function)` check without `$FlowFixMe` (which is forbidden by project rules). - `focus() should not do anything if the TextInput is not editable`: `TextInputState.focusTextInput` reads `textField.currentProps?.editable`, but in the new architecture `currentProps` is not exposed on the public `ReactNativeElement` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching `currentProps`. Documenting this as expected behavior in Fantom would mask a real bug. - `should give precedence to textContentType when set`: `textContentType` is iOS-only and Fantom defaults to Android (`AndroidTextInput`). Files removed: - `Libraries/Components/TextInput/__tests__/TextInput-test.js` - `Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap` Changelog: [Internal] Reviewed By: javache Differential Revision: D101977225

…ebook#56559) Summary: Pull Request resolved: facebook#56559 Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one. Changes in `TextInput-itest.js`: - Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused"). - Add a top-level `has the correct displayName` test. - Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`: - `id and nativeID`: `id` → `nativeID` mapping, `nativeID` pass-through, and `id` precedence over `nativeID`. - `testID`: pass-through. - `aria-label and accessibilityLabel`: `aria-label` → `accessibilityLabel` mapping and `accessibilityLabel` pass-through. - `aria-* and accessibilityState`: `aria-busy/checked/disabled/expanded/selected` mapped into `accessibilityState`. - `accessibilityRole`: pass-through. - `style`: `backgroundColor` propagated as a native color value. Tests intentionally NOT ported: - Inherited `HostInstance` method presence checks (`focus`, `blur`, `setNativeProps`, `measure`, `measureInWindow`, `measureLayout`): they are guaranteed by Flow typing on `ReactNativeElement`, exercised in `ReactNativeElement-itest.js`, and Flow's `method-unbinding` rule prevents the simple `toBeInstanceOf(Function)` check without `$FlowFixMe` (which is forbidden by project rules). - `focus() should not do anything if the TextInput is not editable`: `TextInputState.focusTextInput` reads `textField.currentProps?.editable`, but in the new architecture `currentProps` is not exposed on the public `ReactNativeElement` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching `currentProps`. Documenting this as expected behavior in Fantom would mask a real bug. - `should give precedence to textContentType when set`: `textContentType` is iOS-only and Fantom defaults to Android (`AndroidTextInput`). Files removed: - `Libraries/Components/TextInput/__tests__/TextInput-test.js` - `Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap` Changelog: [Internal] Reviewed By: javache Differential Revision: D101977225

…ebook#56559) Summary: Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one. Changes in `TextInput-itest.js`: - Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused"). - Add a top-level `has the correct displayName` test. - Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`: - `id and nativeID`: `id` → `nativeID` mapping, `nativeID` pass-through, and `id` precedence over `nativeID`. - `testID`: pass-through. - `aria-label and accessibilityLabel`: `aria-label` → `accessibilityLabel` mapping and `accessibilityLabel` pass-through. - `aria-* and accessibilityState`: `aria-busy/checked/disabled/expanded/selected` mapped into `accessibilityState`. - `accessibilityRole`: pass-through. - `style`: `backgroundColor` propagated as a native color value. Tests intentionally NOT ported: - Inherited `HostInstance` method presence checks (`focus`, `blur`, `setNativeProps`, `measure`, `measureInWindow`, `measureLayout`): they are guaranteed by Flow typing on `ReactNativeElement`, exercised in `ReactNativeElement-itest.js`, and Flow's `method-unbinding` rule prevents the simple `toBeInstanceOf(Function)` check without `$FlowFixMe` (which is forbidden by project rules). - `focus() should not do anything if the TextInput is not editable`: `TextInputState.focusTextInput` reads `textField.currentProps?.editable`, but in the new architecture `currentProps` is not exposed on the public `ReactNativeElement` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching `currentProps`. Documenting this as expected behavior in Fantom would mask a real bug. - `should give precedence to textContentType when set`: `textContentType` is iOS-only and Fantom defaults to Android (`AndroidTextInput`). Files removed: - `Libraries/Components/TextInput/__tests__/TextInput-test.js` - `Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap` Changelog: [Internal] Reviewed By: javache Differential Revision: D101977225

…ebook#56559) Summary: Pull Request resolved: facebook#56559 Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one. Changes in `TextInput-itest.js`: - Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused"). - Add a top-level `has the correct displayName` test. - Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`: - `id and nativeID`: `id` → `nativeID` mapping, `nativeID` pass-through, and `id` precedence over `nativeID`. - `testID`: pass-through. - `aria-label and accessibilityLabel`: `aria-label` → `accessibilityLabel` mapping and `accessibilityLabel` pass-through. - `aria-* and accessibilityState`: `aria-busy/checked/disabled/expanded/selected` mapped into `accessibilityState`. - `accessibilityRole`: pass-through. - `style`: `backgroundColor` propagated as a native color value. Tests intentionally NOT ported: - Inherited `HostInstance` method presence checks (`focus`, `blur`, `setNativeProps`, `measure`, `measureInWindow`, `measureLayout`): they are guaranteed by Flow typing on `ReactNativeElement`, exercised in `ReactNativeElement-itest.js`, and Flow's `method-unbinding` rule prevents the simple `toBeInstanceOf(Function)` check without `$FlowFixMe` (which is forbidden by project rules). - `focus() should not do anything if the TextInput is not editable`: `TextInputState.focusTextInput` reads `textField.currentProps?.editable`, but in the new architecture `currentProps` is not exposed on the public `ReactNativeElement` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching `currentProps`. Documenting this as expected behavior in Fantom would mask a real bug. - `should give precedence to textContentType when set`: `textContentType` is iOS-only and Fantom defaults to Android (`AndroidTextInput`). Files removed: - `Libraries/Components/TextInput/__tests__/TextInput-test.js` - `Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap` Changelog: [Internal] Reviewed By: javache Differential Revision: D101977225

meta-codesync · 2026-04-23T13:10:01Z

This pull request has been merged in f69a566.

react-native-bot · 2026-04-23T13:10:03Z

This pull request was successfully merged by @rubennorte in f69a566

^{When will my fix make it into a release? | How to file a pick request?}

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2026

facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels Apr 22, 2026

meta-codesync Bot added fb-exported meta-exported labels Apr 22, 2026

rubennorte force-pushed the export-D101977225 branch from c04ea3e to 304ba5a Compare April 22, 2026 15:53

meta-codesync Bot changed the title ~~Port TextInput-test.js to Fantom and remove the legacy Jest test~~ Port TextInput-test.js to Fantom and remove the legacy Jest test (#56559) Apr 22, 2026

rubennorte force-pushed the export-D101977225 branch from 304ba5a to 21508a7 Compare April 22, 2026 15:53

rubennorte force-pushed the export-D101977225 branch from 21508a7 to 780df1e Compare April 22, 2026 15:56

rubennorte force-pushed the export-D101977225 branch from 780df1e to d3ef9de Compare April 22, 2026 16:26

rubennorte force-pushed the export-D101977225 branch 2 times, most recently from b1c3f5c to 9e38ea1 Compare April 23, 2026 10:14

rubennorte force-pushed the export-D101977225 branch from 9e38ea1 to 4006e68 Compare April 23, 2026 10:17

meta-codesync Bot closed this in f69a566 Apr 23, 2026

facebook-github-tools Bot added the Merged This PR has been merged. label Apr 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port TextInput-test.js to Fantom and remove the legacy Jest test (#56559)#56559

Port TextInput-test.js to Fantom and remove the legacy Jest test (#56559)#56559
rubennorte wants to merge 1 commit intofacebook:mainfrom
rubennorte:export-D101977225

rubennorte commented Apr 22, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

meta-codesync Bot commented Apr 22, 2026

Uh oh!

meta-codesync Bot commented Apr 23, 2026

Uh oh!

react-native-bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rubennorte commented Apr 22, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meta-codesync Bot commented Apr 22, 2026

Uh oh!

meta-codesync Bot commented Apr 23, 2026

Uh oh!

react-native-bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rubennorte commented Apr 22, 2026 •

edited by meta-codesync Bot

Loading