Skip prebuilds for DynamicFrameworks CI jobs#56593
Merged
cipolleschi merged 2 commits into0.83-stablefrom Apr 24, 2026
Merged
Conversation
DynamicFrameworks jobs should always build from source to catch CocoaPods misconfigurations with use_frameworks. Previously, prebuilds were always downloaded and used, masking potential failures.
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
The use-hermes-nightly flag was computed from the branch name, which evaluates incorrectly for PR branches targeting stable. Instead, read the actual HERMES_VERSION_NAME from version.properties and only use nightly when it is the 1000.0.0 development placeholder.
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.83-stablewere incorrectly downloading and using prebuilds (ReactNativeDependencies + ReactCore xcframeworks), which could mask CocoaPods misconfigurations when running withuse_frameworks.test-ios-rntesterandtest-ios-helloworldcomposite actions now conditionally skip prebuild downloads and env vars whenuse-frameworksis set toDynamicFrameworks, ensuring these jobs always build from source.main.Changelog:
[INTERNAL] - Skip prebuilds for DynamicFrameworks CI jobs to always build from source
Test plan
CI should pass — StaticLibraries jobs still use prebuilds as before; DynamicFrameworks jobs will now build from source.