change(ios): make root VC notify on viewDidAppear/-Disappear#56618
Open
hannojg wants to merge 7 commits intofacebook:mainfrom
Open
change(ios): make root VC notify on viewDidAppear/-Disappear#56618hannojg wants to merge 7 commits intofacebook:mainfrom
hannojg wants to merge 7 commits intofacebook:mainfrom
Conversation
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Caution
This is based on the following PR which should be merged first:
RCTViewControllerwhich implements the notify methods added in feat(ios): RCTViewControllerAppearanceListener #56598RCTViewControllersthis is an example for how to use this pattern. It will enable view components to listen to
viewDidAppear:events from their parent UIViewControllers.For react-native core itself this isn't overly relevant, however, for third party navigation libraries such as react-native-screens it is.
Changelog:
[IOS] [CHANGED] - Introduce
RCTViewControllerwhich implements notification methods forviewDidAppear/-DisappearTest Plan:
RN Tester works, compiles and runs.