Fix UBSan float-cast-overflow in BridgingTest.numberTest (#56693)#56693
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Fix UBSan float-cast-overflow in BridgingTest.numberTest (#56693)#56693christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103954447. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 6, 2026
) Summary: Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest UndefinedBehaviorSanitizer: float-cast-overflow xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp:73:3 Test was never completed. The test process might have crashed. Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Test UI: https://www.internalfb.com/intern/testinfra/testrun/22236523178966589 Network: Up: 18KiB Down: 19KiB (reSessionID-47fd7d68-411c-4457-bd30-9da43be7bd6e) Loading targets. Remaining 0/71 1705 dirs read, 2636 targets declared Analyzing targets. Remaining 0/699 23626 actions, 35339 artifacts declared Executing actions. Remaining 0/4161 37:55.2s exec time total Command: test. Finished 1 local, 1256 cache (99% hit) 37:49.9s exec time cached (99%) Time elapsed: 8.6s Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Tests finished: Pass 23. Fail 1. Timeout 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 1 TESTS FAILED ✗ fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest Run $ fdb buck test <args> to debug fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest ^^^ just prefix your previous command! ($ fdb !!) Learn more at https://fburl.com/fdb Use Devmate to fix your errors. Just click the following link: fb-vscode://nuclide.code-compose/devmate/fixtests?run_id=22236523178966589&expiry=2026-05-05T23%3A25%3A46Z&viewer=635101758&signature=43cbc805019cc8a73bade59398f40cf642acd0f57d8fb3377839888ccf52d5d85d5c63d9d0c39ea9956d9aefc641fda19c87c6cdba6136b5a3dd5a67c42cdb92dc4721930a [chpurrer@166047.od /data/sandcastle/boxes/fbsource (b6d9fba9d4)]$ ``` Reviewed By: shwanton Differential Revision: D103954447
christophpurrer
force-pushed
the
export-D103954447
branch
2 times, most recently
from
5817587 to
3c5feca
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 6, 2026
) Summary: Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest UndefinedBehaviorSanitizer: float-cast-overflow xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp:73:3 Test was never completed. The test process might have crashed. Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Test UI: https://www.internalfb.com/intern/testinfra/testrun/22236523178966589 Network: Up: 18KiB Down: 19KiB (reSessionID-47fd7d68-411c-4457-bd30-9da43be7bd6e) Loading targets. Remaining 0/71 1705 dirs read, 2636 targets declared Analyzing targets. Remaining 0/699 23626 actions, 35339 artifacts declared Executing actions. Remaining 0/4161 37:55.2s exec time total Command: test. Finished 1 local, 1256 cache (99% hit) 37:49.9s exec time cached (99%) Time elapsed: 8.6s Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Tests finished: Pass 23. Fail 1. Timeout 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 1 TESTS FAILED ✗ fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest Run $ fdb buck test <args> to debug fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest ^^^ just prefix your previous command! ($ fdb !!) Learn more at https://fburl.com/fdb Use Devmate to fix your errors. Just click the following link: fb-vscode://nuclide.code-compose/devmate/fixtests?run_id=22236523178966589&expiry=2026-05-05T23%3A25%3A46Z&viewer=635101758&signature=43cbc805019cc8a73bade59398f40cf642acd0f57d8fb3377839888ccf52d5d85d5c63d9d0c39ea9956d9aefc641fda19c87c6cdba6136b5a3dd5a67c42cdb92dc4721930a [chpurrer@166047.od /data/sandcastle/boxes/fbsource (b6d9fba9d4)]$ ``` Reviewed By: shwanton Differential Revision: D103954447
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 6, 2026
) Summary: Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest UndefinedBehaviorSanitizer: float-cast-overflow xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp:73:3 Test was never completed. The test process might have crashed. Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Test UI: https://www.internalfb.com/intern/testinfra/testrun/22236523178966589 Network: Up: 18KiB Down: 19KiB (reSessionID-47fd7d68-411c-4457-bd30-9da43be7bd6e) Loading targets. Remaining 0/71 1705 dirs read, 2636 targets declared Analyzing targets. Remaining 0/699 23626 actions, 35339 artifacts declared Executing actions. Remaining 0/4161 37:55.2s exec time total Command: test. Finished 1 local, 1256 cache (99% hit) 37:49.9s exec time cached (99%) Time elapsed: 8.6s Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Tests finished: Pass 23. Fail 1. Timeout 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 1 TESTS FAILED ✗ fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest Run $ fdb buck test <args> to debug fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest ^^^ just prefix your previous command! ($ fdb !!) Learn more at https://fburl.com/fdb Use Devmate to fix your errors. Just click the following link: fb-vscode://nuclide.code-compose/devmate/fixtests?run_id=22236523178966589&expiry=2026-05-05T23%3A25%3A46Z&viewer=635101758&signature=43cbc805019cc8a73bade59398f40cf642acd0f57d8fb3377839888ccf52d5d85d5c63d9d0c39ea9956d9aefc641fda19c87c6cdba6136b5a3dd5a67c42cdb92dc4721930a [chpurrer@166047.od /data/sandcastle/boxes/fbsource (b6d9fba9d4)]$ ``` Reviewed By: shwanton Differential Revision: D103954447
christophpurrer
force-pushed
the
export-D103954447
branch
from
3c5feca to
7745de7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 6, 2026
) Summary: Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest UndefinedBehaviorSanitizer: float-cast-overflow xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp:73:3 Test was never completed. The test process might have crashed. Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Test UI: https://www.internalfb.com/intern/testinfra/testrun/22236523178966589 Network: Up: 18KiB Down: 19KiB (reSessionID-47fd7d68-411c-4457-bd30-9da43be7bd6e) Loading targets. Remaining 0/71 1705 dirs read, 2636 targets declared Analyzing targets. Remaining 0/699 23626 actions, 35339 artifacts declared Executing actions. Remaining 0/4161 37:55.2s exec time total Command: test. Finished 1 local, 1256 cache (99% hit) 37:49.9s exec time cached (99%) Time elapsed: 8.6s Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Tests finished: Pass 23. Fail 1. Timeout 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 1 TESTS FAILED ✗ fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest Run $ fdb buck test <args> to debug fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest ^^^ just prefix your previous command! ($ fdb !!) Learn more at https://fburl.com/fdb Use Devmate to fix your errors. Just click the following link: fb-vscode://nuclide.code-compose/devmate/fixtests?run_id=22236523178966589&expiry=2026-05-05T23%3A25%3A46Z&viewer=635101758&signature=43cbc805019cc8a73bade59398f40cf642acd0f57d8fb3377839888ccf52d5d85d5c63d9d0c39ea9956d9aefc641fda19c87c6cdba6136b5a3dd5a67c42cdb92dc4721930a [chpurrer@166047.od /data/sandcastle/boxes/fbsource (b6d9fba9d4)]$ ``` Reviewed By: shwanton Differential Revision: D103954447
christophpurrer
force-pushed
the
export-D103954447
branch
from
7745de7 to
59ee9ef
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 6, 2026
) Summary: Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest UndefinedBehaviorSanitizer: float-cast-overflow xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp:73:3 Test was never completed. The test process might have crashed. Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Test UI: https://www.internalfb.com/intern/testinfra/testrun/22236523178966589 Network: Up: 18KiB Down: 19KiB (reSessionID-47fd7d68-411c-4457-bd30-9da43be7bd6e) Loading targets. Remaining 0/71 1705 dirs read, 2636 targets declared Analyzing targets. Remaining 0/699 23626 actions, 35339 artifacts declared Executing actions. Remaining 0/4161 37:55.2s exec time total Command: test. Finished 1 local, 1256 cache (99% hit) 37:49.9s exec time cached (99%) Time elapsed: 8.6s Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Tests finished: Pass 23. Fail 1. Timeout 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 1 TESTS FAILED ✗ fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest Run $ fdb buck test <args> to debug fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest ^^^ just prefix your previous command! ($ fdb !!) Learn more at https://fburl.com/fdb Use Devmate to fix your errors. Just click the following link: fb-vscode://nuclide.code-compose/devmate/fixtests?run_id=22236523178966589&expiry=2026-05-05T23%3A25%3A46Z&viewer=635101758&signature=43cbc805019cc8a73bade59398f40cf642acd0f57d8fb3377839888ccf52d5d85d5c63d9d0c39ea9956d9aefc641fda19c87c6cdba6136b5a3dd5a67c42cdb92dc4721930a [chpurrer@166047.od /data/sandcastle/boxes/fbsource (b6d9fba9d4)]$ ``` Reviewed By: shwanton Differential Revision: D103954447
christophpurrer
force-pushed
the
export-D103954447
branch
from
59ee9ef to
f3b5bbf
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 6, 2026
) Summary: Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest UndefinedBehaviorSanitizer: float-cast-overflow xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp:73:3 Test was never completed. The test process might have crashed. Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Test UI: https://www.internalfb.com/intern/testinfra/testrun/22236523178966589 Network: Up: 18KiB Down: 19KiB (reSessionID-47fd7d68-411c-4457-bd30-9da43be7bd6e) Loading targets. Remaining 0/71 1705 dirs read, 2636 targets declared Analyzing targets. Remaining 0/699 23626 actions, 35339 artifacts declared Executing actions. Remaining 0/4161 37:55.2s exec time total Command: test. Finished 1 local, 1256 cache (99% hit) 37:49.9s exec time cached (99%) Time elapsed: 8.6s Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Tests finished: Pass 23. Fail 1. Timeout 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 1 TESTS FAILED ✗ fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest Run $ fdb buck test <args> to debug fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest ^^^ just prefix your previous command! ($ fdb !!) Learn more at https://fburl.com/fdb Use Devmate to fix your errors. Just click the following link: fb-vscode://nuclide.code-compose/devmate/fixtests?run_id=22236523178966589&expiry=2026-05-05T23%3A25%3A46Z&viewer=635101758&signature=43cbc805019cc8a73bade59398f40cf642acd0f57d8fb3377839888ccf52d5d85d5c63d9d0c39ea9956d9aefc641fda19c87c6cdba6136b5a3dd5a67c42cdb92dc4721930a [chpurrer@166047.od /data/sandcastle/boxes/fbsource (b6d9fba9d4)]$ ``` Reviewed By: shwanton Differential Revision: D103954447
christophpurrer
force-pushed
the
export-D103954447
branch
from
f3b5bbf to
ee3b350
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 6, 2026
) Summary: Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest UndefinedBehaviorSanitizer: float-cast-overflow xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp:73:3 Test was never completed. The test process might have crashed. Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Test UI: https://www.internalfb.com/intern/testinfra/testrun/22236523178966589 Network: Up: 18KiB Down: 19KiB (reSessionID-47fd7d68-411c-4457-bd30-9da43be7bd6e) Loading targets. Remaining 0/71 1705 dirs read, 2636 targets declared Analyzing targets. Remaining 0/699 23626 actions, 35339 artifacts declared Executing actions. Remaining 0/4161 37:55.2s exec time total Command: test. Finished 1 local, 1256 cache (99% hit) 37:49.9s exec time cached (99%) Time elapsed: 8.6s Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Tests finished: Pass 23. Fail 1. Timeout 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 1 TESTS FAILED ✗ fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest Run $ fdb buck test <args> to debug fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest ^^^ just prefix your previous command! ($ fdb !!) Learn more at https://fburl.com/fdb Use Devmate to fix your errors. Just click the following link: fb-vscode://nuclide.code-compose/devmate/fixtests?run_id=22236523178966589&expiry=2026-05-05T23%3A25%3A46Z&viewer=635101758&signature=43cbc805019cc8a73bade59398f40cf642acd0f57d8fb3377839888ccf52d5d85d5c63d9d0c39ea9956d9aefc641fda19c87c6cdba6136b5a3dd5a67c42cdb92dc4721930a [chpurrer@166047.od /data/sandcastle/boxes/fbsource (b6d9fba9d4)]$ ``` Reviewed By: shwanton Differential Revision: D103954447
christophpurrer
force-pushed
the
export-D103954447
branch
from
ee3b350 to
6f748fb
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 6, 2026
) Summary: Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest UndefinedBehaviorSanitizer: float-cast-overflow xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp:73:3 Test was never completed. The test process might have crashed. Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Test UI: https://www.internalfb.com/intern/testinfra/testrun/22236523178966589 Network: Up: 18KiB Down: 19KiB (reSessionID-47fd7d68-411c-4457-bd30-9da43be7bd6e) Loading targets. Remaining 0/71 1705 dirs read, 2636 targets declared Analyzing targets. Remaining 0/699 23626 actions, 35339 artifacts declared Executing actions. Remaining 0/4161 37:55.2s exec time total Command: test. Finished 1 local, 1256 cache (99% hit) 37:49.9s exec time cached (99%) Time elapsed: 8.6s Buck UI: https://www.internalfb.com/buck2/0e81623b-a566-4181-a630-633a9b0144f5 Tests finished: Pass 23. Fail 1. Timeout 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 1 TESTS FAILED ✗ fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest Run $ fdb buck test <args> to debug fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridging:tests - BridgingTest.numberTest ^^^ just prefix your previous command! ($ fdb !!) Learn more at https://fburl.com/fdb Use Devmate to fix your errors. Just click the following link: fb-vscode://nuclide.code-compose/devmate/fixtests?run_id=22236523178966589&expiry=2026-05-05T23%3A25%3A46Z&viewer=635101758&signature=43cbc805019cc8a73bade59398f40cf642acd0f57d8fb3377839888ccf52d5d85d5c63d9d0c39ea9956d9aefc641fda19c87c6cdba6136b5a3dd5a67c42cdb92dc4721930a [chpurrer@166047.od /data/sandcastle/boxes/fbsource (b6d9fba9d4)]$ ``` Reviewed By: shwanton Differential Revision: D103954447
christophpurrer
force-pushed
the
export-D103954447
branch
from
6f748fb to
6f41c48
Compare
christophpurrer
force-pushed
the
export-D103954447
branch
from
6f41c48 to
fbb9ba1
Compare
|
This pull request has been merged in f85a777. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in f85a777 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] - Remove UB-relying assertion from BridgingTest.numberTest
Reviewed By: shwanton
Differential Revision: D103954447